Repository navigation
Color links red when they are connected to non-imported task - #35
Merged
Merged
Conversation
loichuder
added this pull request to stack #36
September 15, 2026 07:42
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
loichuder
commented
Sep 15, 2026
Comment on lines
+138
to
+140
| @property | ||
| def import_error(self) -> bool: | ||
| return self._box.get_attr("data-import-error") is not None |
Member
Author
There was a problem hiding this comment.
This is how we expose the import error from SvgTask so that SvgTaskGroup can generate the dict of import errors.
Comment on lines
+40
to
+41
| # FIXME: | ||
| source_task_id = edge["sources"][0].split(".output.")[0] |
Member
Author
There was a problem hiding this comment.
As a mentionned in the PR description, there is implicit coupling added here that we will have to fix.
LudoBroche
approved these changes
Sep 18, 2026
LudoBroche
left a comment
LudoBroche
left a comment
Member
There was a problem hiding this comment.
I found no issue; it's good to merge
loichuder
force-pushed
the
import-error-links
branch
from
September 28, 2026 09:01
5af2cb1 to
c509c09
Compare
loichuder
force-pushed
the
import-error-links
branch
from
October 8, 2026 06:39
c509c09 to
b2af225
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The idea is to generate a dict of
task_id: import_errorand to propagate it down to the SVG creation of the link (build_svg_link_group). Unfortunately, at this point, thetask_idis contained in the edge id under the form{task_id}.[input|output].{port_name}.To retrieve it, we have to parse this edge id, adding some implicit coupling with the edge id creation. I plan to fix this in the next PR.
AI Disclosure