Skip to content

fix engine related type annotations #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woutdenolf merged 1 commit into from
Oct 7, 2026
Merged

fix engine related type annotations #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/ewoks/_engines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from typing import List
from typing import Optional
from typing import Tuple
from typing import Type

from ewokscore.engine_interface import WorkflowEngine
from ewokscore.engine_interface import WorkflowEngineWithSerialization
Expand Down Expand Up @@ -49,7 +50,7 @@ def get_execution_engine(engine_name: Optional[str]) -> WorkflowEngine:

def get_serialization_engine(
graph: Any, representation: Optional[str] = None
) -> Tuple[WorkflowEngine, str]:
) -> Tuple[WorkflowEngineWithSerialization, Optional[str]]:
core_representation = representation
if representation:
for (
Expand All @@ -58,8 +59,9 @@ def get_serialization_engine(
) in _iter_engine_class_loaders_with_representation():
if representation in representations:
engine_cls = load_engine_cls()
engine = engine_cls()
return engine, representation
if not issubclass(engine_cls, WorkflowEngineWithSerialization):
continue
return engine_cls(), representation
else:
for name, load_engine_cls in _iter_engine_class_loaders_with_name():
try:
Expand All @@ -78,10 +80,15 @@ def get_serialization_engine(
if representation:
return engine, representation

return get_execution_engine("core"), core_representation
engine = get_execution_engine("core")
if not isinstance(engine, WorkflowEngineWithSerialization):
raise RuntimeError("The 'core' engine does not support graph serialization")
return engine, core_representation


_EngineClassLoaderGenerator = Generator[Tuple[str, Callable[[], None]], None, None]
_EngineClassLoaderGenerator = Generator[
Tuple[str, Callable[[], Type[WorkflowEngine]]], None, None
]


def _iter_engine_class_loaders_with_name() -> _EngineClassLoaderGenerator:
Expand Down
Loading