Repository navigation
fix(evi): name the memory blob store instead of probing the environment - #785
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evi's memory slot took every session down on a deployment.
fileMemory()with no explicit backend probes the environment: it readsEVE_MEMORY_BLOB_*, then falls back to the project-wideBLOB_*pair. Those point at the public store the screenshot tools upload to. The backend always reads with private access anduseCache: false, which a public store rejects:eve wraps that as
Vercel Blob: Failed to fetch blob: 400 Bad Request, retries the turn three times for a deterministic failure, and escalates toFatalError. The session becomes unrecoverable, so the agent is down rather than the memory slot being empty.Pointing
EVE_MEMORY_BLOB_STORE_IDat a private store moves the failure rather than fixing it: that variable selects the OIDC path, whose authorization is scoped to the environments the store is connected to, and an unconnected environment gets403 Forbiddenthrough the sameFatalError.Naming the backend removes both. The read-write token carries its own store id and never resolves through OIDC, and
BLOB_*is never consulted:Verified against the real store:
Two regression tests cover it, both offline. With
BLOB_STORE_IDandBLOB_READ_WRITE_TOKENset and no memory token, the backend round-trips in process; if the fallback returns, that fails. With the memory token set, a read rejects before any request, proving the blob backend was selected..env.exampledocuments the token and drops the old line pointing ateve add memory/file, which provisions the store-id setup this avoids.No changeset: confined to
apps/evi.