Skip to content

test: exercise the baseline with a real regression - #1

Closed
HugoRCD wants to merge 1 commit into
mainfrom
test/regression
Closed

HugoRCD wants to merge 1 commit into
mainfrom
test/regression

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Not for merging. Removes the log.audit call from the Nuxt fixture's checkout handler so the baseline job sees a regression, the diff gets an ::error on the line, and the sticky comment shows a negative delta.

Summary by CodeRabbit

  • Bug Fixes
    • Baseline comparison annotations now use the baseline reference in place of its local checkout path, making reported file locations clearer in CI output.
  • Chores
    • Updated automated checks to use the Nuxt fixture for report-only and failure-gating runs.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 85d23998-56ea-4b42-a130-8f38bfb51a7e
📥 Commits

Reviewing files that changed from the base of the PR and between 2697769 and 1010781.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4b0882a-15d8-47e2-989d-f0cf9dc91b2d
📥 Commits

Reviewing files that changed from the base of the PR and between 93fa178 and 2697769.

📒 Files selected for processing (1)
  • test/fixtures/nuxt-app/server/api/checkout.post.ts
💤 Files with no reviewable changes (1)
  • test/fixtures/nuxt-app/server/api/checkout.post.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The checkout handler no longer calls log.audit for checkout.completed with the user actor. It still sets user and cart logging context and returns { ok: true }.

Changes

Checkout logging

Layer / File(s) Summary
Checkout handler logging
test/fixtures/nuxt-app/server/api/checkout.post.ts
The handler no longer calls log.audit with the checkout.completed action and user actor. It still sets user and cart logging context and returns { ok: true }.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 26977

This change affects the checkout test fixture, not a production checkout handler. No actionable merge-blocking risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the intended change: remove the checkout audit call to create a regression that exercises the baseline test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

evlog map

Package Score Instrumented Partial Dark Gate
test/fixtures/express-app (express) 100 excellent 2 0 0 passed
test/fixtures/hono-app (hono) 100 excellent 2 0 0 passed
test/fixtures/nuxt-app (nuxt) 56 needs work 2 0 2 passed

Fix first

evlog map v0.7.0 · how the score works · what each check expects

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

evlog map

Package Score Instrumented Partial Dark Gate
nuxt-app (nuxt) 56 needs work 2 0 2 passed

Fix first

evlog map v0.7.0 · how the score works · what each check expects

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

evlog map

Package Score Δ Instrumented Partial Dark Gate
test/fixtures/express-app (express) 100 excellent 0 2 0 0 passed
test/fixtures/hono-app (hono) 100 excellent 0 2 0 0 passed
test/fixtures/nuxt-app (nuxt) 56 needs work -8 2 0 2 failed (regressed)

Regressions (1)

Checks that passed on the base and no longer do.

Fix first

evlog map v0.7.0 · how the score works · what each check expects

@HugoRCD HugoRCD closed this Oct 4, 2026
@HugoRCD
HugoRCD deleted the test/regression branch October 4, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant