fix(descriptors): convert Series to list in semantic_similarity_scoring - #1904
Open
RK0297 wants to merge 1 commit into
Open
fix(descriptors): convert Series to list in semantic_similarity_scoring#1904RK0297 wants to merge 1 commit into
RK0297 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime incompatibility in semantic_similarity_scoring where pandas.Series inputs were passed directly into SentenceTransformer.encode(), which newer sentence-transformers versions reject. It also adds a regression test to ensure encoding inputs are converted to plain Python lists.
Changes:
- Convert
question.data.fillna("")and explodedcontextvalues tolistvia.tolist()before callingmodel.encode(). - Add a unit test verifying both
encode()call sites receivelistarguments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/evidently/descriptors/_context_relevance.py |
Converts filled Series inputs to Python lists before SentenceTransformer.encode() to avoid Unsupported input type: Series. |
tests/descriptors/test_context_relevance.py |
Adds a regression test covering the two encode() call sites and asserting list conversion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR complements #1889 by fixing the second call site where a pandas.Series was passed directly into model.encode() in semantic_similarity_scoring (src/evidently/descriptors/_context_relevance.py).
Newer sentence-transformers versions (5.6.1+) no longer coerce pandas.Series objects, causing a ValueError: Unsupported input type: Series.
Changes
Relates to #1888.