-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add remove_saved_keywords MCP tool #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snayyar00
wants to merge
2
commits into
every-app:main
Choose a base branch
from
snayyar00:pr/remove-saved-keywords
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| import { z } from "zod"; | ||
| import { KeywordResearchService } from "@/server/features/keywords/services/KeywordResearchService"; | ||
| import { buildProjectMeta } from "@/server/mcp/context"; | ||
| import { mcpResponse } from "@/server/mcp/formatters"; | ||
| import { optionalMetaOutputSchema } from "@/server/mcp/output-schemas"; | ||
| import { withMcpProjectAuth } from "@/server/mcp/project-auth"; | ||
| import { projectIdSchema } from "@/server/mcp/schemas"; | ||
|
|
||
| const inputSchema = { | ||
| projectId: projectIdSchema, | ||
| savedKeywordIds: z | ||
| .array(z.string().min(1)) | ||
| .min(1) | ||
| .max(2000) | ||
| .describe( | ||
| "Saved-keyword row IDs to delete. Use the `id` values returned by list_saved_keywords.", | ||
| ), | ||
| } as const; | ||
|
|
||
| type Args = z.infer<z.ZodObject<typeof inputSchema>>; | ||
|
|
||
| export const removeSavedKeywordsTool = { | ||
| name: "remove_saved_keywords", | ||
| config: { | ||
| title: "Remove saved keywords", | ||
| description: | ||
| "Permanently deletes keywords from a project's saved-keywords list by their row ID. Uses no credits — does not call DataForSEO. This does not affect Rank Tracking; use remove_rank_tracking_keywords for that list separately.", | ||
| inputSchema, | ||
| outputSchema: z | ||
| .object({ | ||
| projectId: z.string(), | ||
| requested: z.number(), | ||
| deletedCount: z.number(), | ||
| ...optionalMetaOutputSchema, | ||
| }) | ||
| .passthrough(), | ||
| annotations: { | ||
| readOnlyHint: false, | ||
| openWorldHint: false, | ||
| destructiveHint: true, | ||
| }, | ||
| }, | ||
| handler: withMcpProjectAuth(async (args: Args, context) => { | ||
| const requested = args.savedKeywordIds.length; | ||
| const result = await KeywordResearchService.removeSavedKeywords( | ||
| args.projectId, | ||
| { projectId: args.projectId, savedKeywordIds: args.savedKeywordIds }, | ||
| ); | ||
| return mcpResponse({ | ||
| text: `Deleted ${result.deletedCount} of ${requested} requested saved keyword${requested === 1 ? "" : "s"}.`, | ||
| meta: buildProjectMeta( | ||
| context, | ||
| args.projectId, | ||
| `/p/${args.projectId}/saved`, | ||
| ), | ||
| structuredContent: { | ||
| projectId: args.projectId, | ||
| requested, | ||
| deletedCount: result.deletedCount, | ||
| }, | ||
| }); | ||
| }), | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an MCP client surfaces only text content, it cannot supply this parameter:
list_saved_keywordsrenders keyword, metrics, and tags atsrc/server/mcp/tools/list-saved-keywords.ts:65-73, but leaves each row'sidonly instructuredContent. The repository explicitly supports text-only MCP clients, so following this instruction still leaves those clients unable to use the new removal flow; include the row ID inlist_saved_keywords's text output or accept an identifier already shown there.Useful? React with 👍 / 👎.