fix(audit): keep results tabs clickable while Export is open - #301
Open
jackwalkerlabs wants to merge 2 commits into
Open
jackwalkerlabs wants to merge 2 commits into
jackwalkerlabs wants to merge 2 commits into
Conversation
Use explicit menu state and preserve outside clicks, export actions, and keyboard dismissal. Cover the completed audit route with opt-in E2E fixtures and declare its Vite environment flag. Fixes every-app#223
jackwalkerlabs
marked this pull request as ready for review
September 7, 2026 17:14
ywwenjin163
pushed a commit
to ywwenjin163/open-seo
that referenced
this pull request
Sep 12, 2026
…#283)" (every-app#301) This reverts commit 0adf778.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening Export on a completed audit can prevent a single click from switching Issues, Pages, or Performance. This changes the shared menu to explicit open state so the outside click dismisses it and reaches the selected tab. Export actions, Escape/focus restoration, and keyboard navigation remain available.
Proof of concept for #223, following the contribution guide's allowance for reference PRs. Prepared with Codex.
The regression uses the actual completed-audit route with opt-in fixture data, dismisses the first-run setup dialog, and checks all three tabs, CSV download, Escape/focus restoration, and outside dismissal. The fixture flag is declared in
ImportMetaEnvand enabled by the existing Playwright setup.Validation on exact head
df0a342f5fce5f8cbd9ce6a31937d0ea7923a8f4:DockerRunner.verifyandDockerRunner.runValidationon Solo (runtime8b9680d7, validation IDFC-20260907-F0BDD6), with a separate validation database; this is not a new production-dashboard run. The committed test was unchanged. A runner adapter used system Chromium, Factory-managed Vite startup, and Playwright-to-Factory reporting.local_noauthsetup were used; no paid-provider credentials or requests. The PR worktree remained clean at the validated SHA.An earlier macOS existing-profile Chrome/CUA attempt crashed during mouse tab navigation with both the original UI and this change. That crash remains unexplained; the full requested interaction scenario now passes in Factory's Linux browser environment. No production deployment or complete repository-wide E2E-suite pass is claimed.