Repository navigation
DEVPROD-45393: Wait for new distro menu to unmount in tests - #2038
Open
matt-meisinger wants to merge 1 commit into
Open
matt-meisinger wants to merge 1 commit into
matt-meisinger wants to merge 1 commit into
Conversation
matt-meisinger
force-pushed
the
fix-menu-unmount-assertions
branch
from
October 16, 2026 18:43
a376cad to
bb36a30
Compare
matt-meisinger
marked this pull request as ready for review
October 16, 2026 19:49
pr-issue-creator
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVPROD-XXXX
Description
Fixes a flaky
NewDistroButtonunit test that failed 3 times in the last month. The currentqueryByTestId("new-distro-menu").not.toBeVisible()check can throw (received value must be an HTMLElement or an SVGElement) when when the check should just pass (the element has left the DOM just like we wanted it to). The test now waits for the menu to leave the DOM.Testing
The
NewDistroButton.test.tsxunit test passed when run 15 times in quick succession.