docs(guides): add Results & Scoring guide - #120
Merged
Merged
Conversation
Document how EvalHub calculates evaluation test results so users can understand and reproduce the numbers on the job resource. The existing collections guide covers the config side but not the results shape itself. This adds a dedicated guide explaining: - the two test fields: per-benchmark results.benchmarks[].test and the job-level results.test - how each benchmark's primary score, threshold, and pass/fail are derived, including lower_is_better handling - the weighted-mean job aggregation and its skip conditions - the override precedence for primary metric, threshold, and weight - a dedicated section on non-numeric metrics: only numeric values are scored, and how non-numeric primary metrics cascade to an omitted test block and are excluded from the job average Generated with: Claude Code Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Julian Payne <julpayne@redhat.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Caution Review failedAn error occurred during the review process. Please try again later. 📝 WalkthroughWalkthroughThe pull request adds a Results & Scoring guide and links it from the Guides sidebar. The guide documents per-benchmark scoring, job-level aggregation, configuration precedence, examples, and conditions that omit results. ChangesResults and Scoring Guide
Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a dedicated Guides → Results & Scoring page documenting how EvalHub calculates the
testvalues on a completed evaluation job — both the per-benchmarkresults.benchmarks[].testand the job-levelresults.test— and the user overrides that affect them.The existing Collections guide covers the configuration side (weights, primary scores, thresholds) but not the shape or derivation of the results themselves. This new page fills that gap and cross-links back to Collections.
What the page covers
testfields — per-benchmark vs. job-level, with a fullresultsJSON example.test— how the primary metric, threshold, and pass/fail are derived (includinglower_is_better), and when the block is omitted.test— the weighted-mean formula,1 − scoreinversion forlower_is_betterbenchmarks, and skip conditions.testblock → excluded from the job average →results.testomitted if nothing is numeric.All content is grounded in the scoring implementation (
computeBenchmarkTestResult,computeJobTestResult,getPassCriteriaThreshold,castAnyToFloat32) and the API result structs.Sidebar
Added under Guides, between Job Lifecycle & States and Collections.
Validation
astro syncregenerates content collections and types with no errors. (An unrelated pre-existingasciinema-playerbundling error affectsastro buildin this checkout and is not touched by this PR.)🤖 Generated with Claude Code
Summary by CodeRabbit