fix(remediation): sync PR title/body even when fix commit is a no-op - #20
Merged
Conversation
remediateOne returned early once CommitFiles reported no tree change, skipping CreateOrUpdatePullRequest entirely. An already-fixed branch with a stale PR title/body (e.g. from before the conventional-commit title change) never got synced, since sync only ran on a fresh commit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 78.06% 78.16% +0.10%
==========================================
Files 41 41
Lines 3159 3156 -3
==========================================
+ Hits 2466 2467 +1
+ Misses 550 548 -2
+ Partials 143 141 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remediateOnereturned early onceCommitFilesreported a no-op tree (branch already matches the fix), skippingCreateOrUpdatePullRequestentirely — an already-fixed branch with a stale PR title/body never got synced.reearth/reearth-accounts: PR #307'sactions-pinnedfix branch was already correct, but the title never picked up the conventional-commit format from fix(remediation): use conventional-commit PR titles and sync existing PRs #19.CommitFiles, whether or not a new commit was made.Test plan
go build ./...go vet ./...go test ./...TestRun_SyncsPRTitleWhenCommitIsNoOpregression test covering the no-op-commit-but-stale-PR case