build(deps): bump go-github to v90.0.0 - #17
Merged
Conversation
Repository, jwt, cobra, and yaml.v3 modules were already at latest stable; only go-github needed the jump from v84 to v90. Adapts to the resulting API breaks: NewClient's options-func constructor, WithEnterpriseURLs as a ClientOptionsFunc instead of a client method, PullRequests.Create's CreatePullRequest type, Issues.Create/Update's split Create/UpdateIssueRequest types, and Repositories.GetRulesForBranch renamed to ListRulesForBranch.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 76.16% 78.08% +1.91%
==========================================
Files 41 41
Lines 3151 3153 +2
==========================================
+ Hits 2400 2462 +62
+ Misses 616 549 -67
- Partials 135 142 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
auth.go and repos.go had no direct unit tests before this bump, so the lines touched by the client-constructor and method-rename changes showed up as uncovered patch lines. Adds direct tests for client construction, GitHub App installation-token exchange, and the renamed ListRulesForBranch call, plus an error-path test for issue creation failure in findOrCreateIssueByTitle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/google/go-githubfrom v84.0.0 to v90.0.0 (other direct/indirect Go modules — jwt, cobra, yaml.v3, go-querystring, mousetrap, pflag — were already at latest stable).NewClient's new options-func constructor (returns(*Client, error)),WithEnterpriseURLsmoving from a client method to aClientOptionsFunc,PullRequests.CreatetakingCreatePullRequestby value,Issues.Create/Issues.Updatesplitting intoCreateIssueRequest/UpdateIssueRequest, andRepositories.GetRulesForBranchrenamed toListRulesForBranch.Test plan
go build ./...go vet ./...go test -race -coverprofile=coverage.out -covermode=atomic ./...(matches CI) — all packages pass