fix: raise the smallest text size to 14px - #19
Open
myelinated-wackerow wants to merge 1 commit into
Open
myelinated-wackerow wants to merge 1 commit into
myelinated-wackerow wants to merge 1 commit into
Conversation
12px was the one text size below the floor for this site; everything else already sat at 14px or above. Bumping the token rather than replacing its call sites keeps the change to two lines and clear of the feedback branches, which add many more uses of it. Folding the token into the scale is a separate cleanup. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Co-Authored-By: wackerow <54227730+wackerow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raises the smallest text size on the site from 12px to 14px by bumping the
--text-tinytoken, the only size below that floor. Everything that used it moves up together: table headers, chips, captions, helper text, the click-to-explain popover. Compiled stylesheet included.Why the token and not the call sites
Two lines, and clear of the feedback branches (#17 and the branch stacked on it), which add many more uses of the same token. Replacing call sites now would conflict with both.
The token's name is now a misnomer: it is 14px like
text-label-smandtext-label-md. Folding it into the scale, and more broadly preferring Tailwind's native utilities over the Figma-named tokens, is proposed in #18.Verify
pnpm run build:cssreproduces the committed stylesheet. Nothing insrc/sets a size below 14px:text-xs,<small>andtext-[1Npx]do not occur.Claude Fable 5.1