feat: mnemonic profile derive - #74
Merged
kassandraoftroy merged 2 commits intoSep 18, 2026
Merged
Conversation
kassandraoftroy
changed the base branch from
master
to
feat/simplify-networks
September 14, 2026 16:13
kassandraoftroy
marked this pull request as ready for review
September 14, 2026 16:15
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
built on top of and PR into #73
Closes #33 . Overlaps a bit with but does not complete #35 .
Important Design Decisions
Profiles are what users name. Mnemonics are numbered background seeds (
mnemonic 0,mnemonic 1). Noedw mnemoniccommands, API purposefully references named profiles over mnemonics.First unlock of a new instance generates a 12-word seed, creates mnemonic 0 + profile 0, and prints the phrase once. User can rename this profile but it starts with name "default."
The
generate/import/addcommands all create exactly one profile at--index(default 0).Anti-patterns. Importing a phrase that is already stored errors (use
profile addinstead). Creating an existing(mnemonic, index)pair errors. Profile display names must be unique.Storage: mnemonic records (storage index + phrase) and profile records
(mnemonic_index, profile_index, optional name)plus a pointer atprofile:{m}:{p}.profile_indexis BIP44 accountm/44'/60'/<profileIndex>'/…. HD keys are not persisted yet.CLI
profile generatecreates a new mnemonic and initializes a profile on the desired--index.profile importimports a mnemonic and initializes a profile on the desired--index.profile addadds a new profile index on an already existing/stored mnemonic.