Repository navigation
Conversation
…ment load_env() calls load_dotenv(), which finds the repo's .env. With a real HUNTER_API_KEY in it the test fails, and pytest prints the key in the assertion diff. Stub load_dotenv so the test only sees what it sets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B4tcpnvC8VAkRoRkM7JWNF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_load_env_reads_environmentdeletesHUNTER_API_KEYfrom the environment, then callsload_env().load_env()callsload_dotenv(), which finds the repo's.envand loads it back in. So on any machine where.envhas a real Hunter key:assert env.hunter_api_key == ""), andCI has no
.env, so CI passes. The failure only appears locally, once a key is set.Fix
Stub
harvey.config.load_dotenvinside the test, so it only sees the variables it sets itself. That's 2 lines, and no production code changes.Testing
pytest -q tests/test_config_extra.py: 18 passed, with a realHUNTER_API_KEYin.env. It failed before this change.🤖 Generated with Claude Code
https://claude.ai/code/session_01B4tcpnvC8VAkRoRkM7JWNF