Skip to content

Remove connector settings page #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GregorShear wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove connector settings page #1982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/app/routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ const admin = {
path: 'api',
fullPath: '/admin/api',
},
connectors: {
title: 'routeTitle.admin.connectors',
path: 'connectors',
fullPath: '/admin/connectors',
},
billing: {
title: 'routeTitle.admin.billing',
path: 'billing',
Expand Down
32 changes: 0 additions & 32 deletions src/components/admin/Connectors.tsx
View file
Open in desktop

This file was deleted.

16 changes: 6 additions & 10 deletions src/components/admin/Tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,12 @@ function AdminTabs() {
});
}

return response.concat([
{
labelMessageId: 'admin.tabs.connectors',
path: authenticatedRoutes.admin.connectors.fullPath,
},
{
labelMessageId: 'admin.tabs.api',
path: authenticatedRoutes.admin.api.fullPath,
},
]);
response.push({
labelMessageId: 'admin.tabs.api',
path: authenticatedRoutes.admin.api.fullPath,
});

return response;
}, [hasAnyAccess]);

return <NavigationTabs keyPrefix={TAB_KEY} tabs={tabProps} />;
Expand Down
13 changes: 0 additions & 13 deletions src/context/Router/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { authenticatedRoutes, unauthenticatedRoutes } from 'src/app/routes';
import AccessGrants from 'src/components/admin/AccessGrants';
import AdminApi from 'src/components/admin/Api';
import AdminBilling from 'src/components/admin/Billing';
import AdminConnectors from 'src/components/admin/Connectors';
import AdminSettings from 'src/components/admin/Settings';
import { ErrorImporting } from 'src/components/shared/ErrorImporting';
import HasSupportRoleGuard from 'src/components/shared/guards/SupportRole';
Expand Down Expand Up @@ -720,18 +719,6 @@ const router = createBrowserRouter(
/>
</Route>

<Route
path={authenticatedRoutes.admin.connectors.path}
element={
<ErrorBoundary
FallbackComponent={ErrorImporting}
>
<Suspense fallback={null}>
<AdminConnectors />
</Suspense>
</ErrorBoundary>
}
/>
<Route
path={authenticatedRoutes.admin.billing.path}
element={
Expand Down
1 change: 0 additions & 1 deletion src/lang/en-US/AdminPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ export const AdminPage: Record<string, string> = {

'admin.tabs.users': `Account Access`,
'admin.tabs.notifications': `Notifications`,
'admin.tabs.connectors': `Connectors`,
'admin.tabs.api': `CLI-API`,
'admin.tabs.billing': `Billing`,
'admin.tabs.settings': `Settings`,
Expand Down
1 change: 0 additions & 1 deletion src/lang/en-US/RouteTitles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export const RouteTitles: Record<string, string> = {
'routeTitle.admin.accessGrants': `Access Grants`,
'routeTitle.admin.api': `CLI - API`,
'routeTitle.admin.billing': `Billing`,
'routeTitle.admin.connectors': `Connectors`,
'routeTitle.admin.settings': `Settings`,
'routeTitle.captureCreate': `Create Capture`,
'routeTitle.captureDetails': `Capture Details`,
Expand Down
Loading