Skip to content

error handling - #39

Merged
freesig merged 2 commits into
mainfrom
supiket/error-handling
Oct 22, 2025
Merged

error handling#39
freesig merged 2 commits into
mainfrom
supiket/error-handling

Conversation

@bengybade

Copy link
Copy Markdown
Contributor

Closes #26

@bengybade bengybade self-assigned this Oct 20, 2025
@bengybade
bengybade requested review from freesig and nfurfaro October 20, 2025 20:38
@bengybade
bengybade marked this pull request as ready for review October 20, 2025 20:38

@freesig freesig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good expect for some panics that should be results

Comment thread crates/oracle/src/lib.rs Outdated
Comment thread crates/oracle/src/lib.rs Outdated
Comment thread crates/oracle/src/lib.rs Outdated
Comment thread crates/oracle/src/lib.rs Outdated
Comment thread crates/oracle/src/lib.rs Outdated
Comment thread crates/oracle/src/lib.rs Outdated
Comment thread crates/oracle/src/lib.rs Outdated
@bengybade
bengybade requested a review from freesig October 22, 2025 16:32

@nfurfaro nfurfaro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one.

@freesig freesig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@freesig
freesig merged commit 51d98d3 into main Oct 22, 2025
15 checks passed
@freesig
freesig deleted the supiket/error-handling branch October 22, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return and Handle Errors

3 participants