Try errors - #37
Merged
Merged
Conversation
freesig
force-pushed
the
freesig/try-errors
branch
2 times, most recently
from
October 23, 2025 01:43
f534c9d to
bbfdc47
Compare
nfurfaro
approved these changes
Oct 23, 2025
nfurfaro
left a comment
nfurfaro
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, only one question.
| .map(move |block| { | ||
| state.access(|state| apply_transition(block, state, block_state_transition)) | ||
| }) | ||
| // .state_transition_sync(state, block_state_transition) |
This propogates errors along streams. It removes the state transition and extensions helpers in favor of a simple `apply_transform` function. Sign and Proof now return their errors. Implements for `TryStream` instead of `Stream` <!-- ps-id: 9db57b75-725d-436e-9755-9876db1c7316 -->
freesig
force-pushed
the
freesig/try-errors
branch
from
October 23, 2025 19:58
bbfdc47 to
6427530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This propogates errors along streams.
It removes the state transition and extensions helpers in favor of a simple
apply_transformfunction.Try versions of key helpers have been added.
Sign and Proof now return their errors.