Error handling - #32
Merged
Merged
Conversation
bengybade
marked this pull request as ready for review
October 15, 2025 20:15
nfurfaro
approved these changes
Oct 15, 2025
| // Process block. | ||
| let state_transition_func = | ||
| this.state_transition_func.take().expect("is always Some"); | ||
| let pre_extension = this.pre_extension.take().expect("is always Some"); |
Collaborator
There was a problem hiding this comment.
I thought that the pre and post extensions were optional and might very well be None... I may have imagined that though.
Collaborator
There was a problem hiding this comment.
Ah, ignore my previous comment, this is fine in this context.
| { | ||
| let mut lock = self.lock.lock().unwrap(); | ||
| // Not attempting poison recovery. | ||
| let mut lock = self.lock.lock().expect("poisoned lock"); |
Collaborator
There was a problem hiding this comment.
I think this is ok? We're trying to build our software to avoid panics so I would think that a PoisonError should never happen in production. (Not in general, but in parts ofvoid-base dealing with locks specifically).
Contributor
There was a problem hiding this comment.
If it's poisoned then something has panicked so the only thing you can really do is also panic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20