Adds Sqlite to db options - #50
Merged
Merged
Conversation
freesig
commented
Aug 4, 2025
freesig
commented
Collaborator
- Sqlite db implements all writes and queries
- tests
- closes Add sqlite version of db #49
freesig
force-pushed
the
freesig/sqlite
branch
9 times, most recently
from
August 4, 2025 03:36
c53a28a to
6e796c1
Compare
- Sqlite db implements all writes and queries - tests - closes #49 <!-- ps-id: 6d141b80-791e-4fa6-9cea-9efd24ea6d2a -->
nfurfaro
approved these changes
Aug 5, 2025
nfurfaro
left a comment
nfurfaro
left a comment
Contributor
There was a problem hiding this comment.
Looks clean! Just left one question.
| let mut i = 0; | ||
| let parent_hash = loop { | ||
| match get_current_hash(&database).await { | ||
| match get_current_hash(&mut database).await { |
Contributor
There was a problem hiding this comment.
What is it about Sqlite that requires the database arg here to be mutable now?
Collaborator
Author
There was a problem hiding this comment.
It's because the queries have to be executed in a spawn_blocking which requires a 'static type so you need to actually move out the Connection in order to move it into the other thread and then move it back again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.