Repository navigation
Fixed Windows runners not properly storing acquired ENV variables - #73
Conversation
👋 Hello jakub-kocka, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Fixes Windows runner environment propagation for dynamically acquired ESP-IDF versions.
Changes:
- Maps workflow outputs to job-level environment variables.
- Validates resolved versions before builds.
- Passes variables to ARM Docker builds and documents the pattern.
| File | Description |
|---|---|
README.md |
Documents output-to-environment mapping. |
.github/workflows/build-wheels-platforms.yml |
Corrects environment propagation and adds validation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@mfialaf, PTAL |
mfialaf
left a comment
There was a problem hiding this comment.
I dispatched platforms-dispatches on fix/versions (3124aca). The Windows job prints 5.3 in both places: Building for IDF v5.3 and newer and ENV variables: IDF v5.3.
LGTM!
|
Thank you for the test and review. I am merging this. |
Description
From the pipeline (https://github.com/espressif/idf-python-wheels/actions/runs/35801667900/job/106993203981#step:20:69) it can be seen that the Windows runner is using the default fallback ENV variable instead of the ones automatically acquired via Get Supported Versions job
Related
Correct behaviour on other runners: https://github.com/espressif/idf-python-wheels/actions/runs/35801667900/job/106993203824#step:18:27
Testing