Skip to content

Fixed Windows runners not properly storing acquired ENV variables - #73

Merged
jakub-kocka merged 1 commit into
mainfrom
fix/versions
Sep 29, 2026
Merged

jakub-kocka merged 1 commit into
mainfrom
fix/versions

Conversation

@jakub-kocka

Copy link
Copy Markdown
Collaborator

Description

From the pipeline (https://github.com/espressif/idf-python-wheels/actions/runs/35801667900/job/106993203981#step:20:69) it can be seen that the Windows runner is using the default fallback ENV variable instead of the ones automatically acquired via Get Supported Versions job

Related

Correct behaviour on other runners: https://github.com/espressif/idf-python-wheels/actions/runs/35801667900/job/106993203824#step:18:27

Testing

@jakub-kocka jakub-kocka self-assigned this Sep 24, 2026
@jakub-kocka
jakub-kocka requested a lite review from Copilot September 24, 2026 10:50
@github-actions

Copy link
Copy Markdown
Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3124aca

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Fixes Windows runner environment propagation for dynamically acquired ESP-IDF versions.

Changes:

  • Maps workflow outputs to job-level environment variables.
  • Validates resolved versions before builds.
  • Passes variables to ARM Docker builds and documents the pattern.
File Description
README.md Documents output-to-environment mapping.
.github/​workflows/​build-wheels-platforms.yml Corrects environment propagation and adds validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@jakub-kocka
jakub-kocka requested a review from mfialaf September 24, 2026 10:54
@jakub-kocka

Copy link
Copy Markdown
Collaborator Author

@mfialaf, PTAL

@mfialaf mfialaf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dispatched platforms-dispatches on fix/versions (3124aca). The Windows job prints 5.3 in both places: Building for IDF v5.3 and newer and ENV variables: IDF v5.3.

LGTM!

@jakub-kocka

Copy link
Copy Markdown
Collaborator Author

Thank you for the test and review. I am merging this.

@jakub-kocka
jakub-kocka merged commit 690e21f into main Sep 29, 2026
119 checks passed
@jakub-kocka
jakub-kocka deleted the fix/versions branch September 29, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants