Skip to content

Added test workflow to install builded wheels before the upload - #58

Merged
jakub-kocka merged 11 commits into
mainfrom
feat/added_tests
Mar 2, 2026
Merged

jakub-kocka merged 11 commits into
mainfrom
feat/added_tests

Conversation

@jakub-kocka

@jakub-kocka jakub-kocka commented Jan 26, 2026 •

Copy link
Copy Markdown
Collaborator

Description

  • Added/Fixed unit tests and made them automatically run on PR

  • Added installation tests for built wheels before upload to Espressif's PyPI

    • Also, another layer of exclusion mechanism is added for the dependencies of dependencies - everything that we have actually built is again verified with the exclude_list and removed from the packages which will be uploaded
    • Merged wheels in the repair step of the workflow to actually test platform-independent wheels on all platforms and Python versions in the test step
  • Introduced architecture resolver for exclude_list.yaml

  • Added another verification workflow that runs on every PR to actually check what is uploaded in the S3 and if there are exclude list "violations" - might be from manual wheels upload (highly likely not complete wheel) ... this check also runs after the upload of main builds to check if we have not uploaded anything that we don't want to

  • Fixed the new issues - https://github.com/espressif/idf-python-wheels/actions/runs/21887651772

  • Upload has been enhanced in logging scope as well to actually show a completely new package being uploaded (green colour and ++), also statistics are implemented at the end of uploading:

---------- STATISTICS ---------- 
New wheels: 140 
Existing wheels (re-uploaded): 1298
Total uploaded: 1438
---------- END STATISTICS ---------- 

Related

  • internal tracker: IDF-14066

Testing

Unit tests: https://github.com/espressif/idf-python-wheels/actions/runs/22572167881/job/65382577835?pr=58
Action run platforms-dispatch: https://github.com/espressif/idf-python-wheels/actions/runs/22433208706
Action run defined-wheel: https://github.com/espressif/idf-python-wheels/actions/runs/22344842180


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@jakub-kocka jakub-kocka self-assigned this Jan 26, 2026
@github-actions

github-actions Bot commented Jan 26, 2026 •

Copy link
Copy Markdown
Warnings
⚠️ Please consider squashing your 11 commits (simplifying branch history).
Messages
📖 This PR seems to be quite large (total lines of code: 2337), you might consider splitting it into smaller PRs

👋 Hello jakub-kocka, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against dfbdc1b

@jakub-kocka
jakub-kocka force-pushed the feat/added_tests branch 3 times, most recently from d660b51 to 3994296 Compare January 29, 2026 08:27
@jakub-kocka
jakub-kocka marked this pull request as draft January 29, 2026 13:22
@jakub-kocka
jakub-kocka force-pushed the feat/added_tests branch 21 times, most recently from d3e68a3 to f92957f Compare February 2, 2026 08:25
@jakub-kocka
jakub-kocka force-pushed the feat/added_tests branch 4 times, most recently from 472bc8a to 4f9980a Compare February 26, 2026 08:02
@jakub-kocka

Copy link
Copy Markdown
Collaborator Author

Thank you, @dobairoland, for your review. I hope all the comments are properly addressed and that the PR is ready.
I have introduced the regex S3 violation exclusion mechanism to allow us to specify some false positives (got uploaded earlier), which are probabbly OK.

Here is the list of the ones we should remove to be sure it is not broken (https://github.com/espressif/idf-python-wheels/actions/runs/22483758844/job/65130553923?pr=58):

 - esptool-4.11.0-py3-none-any.whl
  - esptool-5.1.0-py3-none-any.whl
  - gdbgui-0.13.2.0-py3-none-any.whl
  - pyobjc_framework_cocoa-10.3.2-cp314-cp314-macosx_10_15_universal2.whl
  - pyobjc_framework_cocoa-10.3.2-cp314-cp314-macosx_10_15_x86_64.whl
  - pyobjc_framework_cocoa-10.3.2-cp314-cp314-macosx_11_0_arm64.whl
  - pyobjc_framework_cocoa-10.3.2-cp314-cp314-macosx_11_0_universal2.whl
  - pyobjc_framework_libdispatch-10.3.2-cp314-cp314-macosx_10_15_universal2.whl
  - pyobjc_framework_libdispatch-10.3.2-cp314-cp314-macosx_10_15_x86_64.whl
  - pyobjc_framework_libdispatch-10.3.2-cp314-cp314-macosx_11_0_arm64.whl
  - pyobjc_framework_libdispatch-10.3.2-cp314-cp314-macosx_11_0_universal2.whl

@dobairoland

Copy link
Copy Markdown
Collaborator

@copilot check that all my comments are properly addressed

Copilot AI commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

@dobairoland I've opened a new pull request, #59, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test_wheels_install.py
Comment thread .github/workflows/wheels-repair.yml
Comment thread .github/workflows/build-wheels-defined.yml
Comment thread README.md Outdated
Comment thread _helper_functions.py
Comment thread _helper_functions.py

@dobairoland dobairoland left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-kocka
jakub-kocka force-pushed the feat/added_tests branch 6 times, most recently from 33d933d to 88b7ad3 Compare March 2, 2026 10:29
@jakub-kocka

Copy link
Copy Markdown
Collaborator Author

Thank you, guys, for the reviews and help with exclude_list violations! I have updated the output of the S3 violations to be the paths to the packages (based on the discussion), to allow us to more easily remove these packages.

I will merge this.

@jakub-kocka
jakub-kocka merged commit 3b319dd into main Mar 2, 2026
11 of 12 checks passed
@dobairoland
dobairoland deleted the feat/added_tests branch March 4, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants