Repository navigation
Added test workflow to install builded wheels before the upload - #58
Conversation
👋 Hello jakub-kocka, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
d660b51 to
3994296
Compare
d3e68a3 to
f92957f
Compare
472bc8a to
4f9980a
Compare
4f9980a to
0d6836d
Compare
|
Thank you, @dobairoland, for your review. I hope all the comments are properly addressed and that the PR is ready. Here is the list of the ones we should remove to be sure it is not broken (https://github.com/espressif/idf-python-wheels/actions/runs/22483758844/job/65130553923?pr=58): |
|
@copilot check that all my comments are properly addressed |
|
@dobairoland I've opened a new pull request, #59, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
33d933d to
88b7ad3
Compare
88b7ad3 to
dfbdc1b
Compare
|
Thank you, guys, for the reviews and help with exclude_list violations! I have updated the output of the S3 violations to be the paths to the packages (based on the discussion), to allow us to more easily remove these packages. I will merge this. |
Description
Added/Fixed unit tests and made them automatically run on PR
Added installation tests for built wheels before upload to Espressif's PyPI
repair stepof the workflow to actually test platform-independent wheels on all platforms and Python versions in thetest stepIntroduced architecture resolver for
exclude_list.yamlAdded another verification workflow that runs on every PR to actually check what is uploaded in the S3 and if there are exclude list "violations" - might be from manual wheels upload (highly likely not complete wheel) ... this check also runs after the upload of main builds to check if we have not uploaded anything that we don't want to
Fixed the new issues - https://github.com/espressif/idf-python-wheels/actions/runs/21887651772
Upload has been enhanced in logging scope as well to actually show a completely new package being uploaded (green colour and ++), also statistics are implemented at the end of uploading:
Related
Testing
Unit tests: https://github.com/espressif/idf-python-wheels/actions/runs/22572167881/job/65382577835?pr=58
Action run platforms-dispatch: https://github.com/espressif/idf-python-wheels/actions/runs/22433208706
Action run defined-wheel: https://github.com/espressif/idf-python-wheels/actions/runs/22344842180
Checklist
Before submitting a Pull Request, please ensure the following: