Repository navigation
Add the BK72xx flasher id to the hand-off protocol - #2862
Conversation
|
@esphbot review |
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 296 296
Lines 25618 25618
=======================================
Hits 25556 25556
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
PR Review — Add the BK72xx flasher id to the hand-off protocolMerge-ready: this adds What the PR does well:
No issues need attention. Checklist
Automated review by Kōan (Claude) |
esphbot
left a comment
There was a problem hiding this comment.
Tip
No blocking issues found — ready to merge.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments; the change is limited to protocol types and documentation.
Review effort: Lite
Findings: None
What changed in this PR
Adds the bk-uart flasher identifier to the BK72xx hand-off protocol.
Changes:
- Extends
HandoffFlasherwithbk-uart. - Documents BK72xx UF2 hand-off behavior.
| File | Summary |
|---|---|
flasher/src/protocol.ts |
Adds and documents the BK72xx flasher identifier. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
What does this implement/fix?
Adds
bk-uart, the UART downloader of a Beken BK72xx, to the flasher ids of the web.esphome.io hand-off in the protocol's mirror here. Types and comments only: the test page still listsespalone, so its handshake test is as it was.Related issue or feature (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocsmaintenancecidependenciesFrontend coordination
Checklist
ruff,codespell, yaml/json/python checks).tests/where applicable.components.index.json/definitions/components/*.jsonhave not been hand-edited (regenerate viascript/sync_components.pyif a sync is needed).docs/ARCHITECTURE.mdand/ordocs/API.md.