Skip to content

Add the BK72xx flasher id to the hand-off protocol - #2862

Merged
bdraco merged 1 commit into
mainfrom
handoff-flasher-ids
Sep 28, 2026
Merged

bdraco merged 1 commit into
mainfrom
handoff-flasher-ids

Conversation

@bdraco

@bdraco bdraco commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

What does this implement/fix?

Adds bk-uart, the UART downloader of a Beken BK72xx, to the flasher ids of the web.esphome.io hand-off in the protocol's mirror here. Types and comments only: the test page still lists esp alone, so its handshake test is as it was.

Related issue or feature (if applicable):

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — docs
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Frontend coordination

Checklist

  • The code change is tested and works locally.
  • Pre-commit hooks pass (ruff, codespell, yaml/json/python checks).
  • Tests have been added or updated under tests/ where applicable.
  • components.index.json / definitions/components/*.json have not been hand-edited (regenerate via script/sync_components.py if a sync is needed).
  • Architecture-level changes are reflected in docs/ARCHITECTURE.md and/or docs/API.md.

@bdraco bdraco added enhancement Improvement to an existing feature maintenance Maintenance / chores and removed enhancement Improvement to an existing feature labels Sep 28, 2026
@bdraco

bdraco commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

@esphbot review

@github-actions github-actions Bot added enhancement Improvement to an existing feature and removed maintenance Maintenance / chores labels Sep 28, 2026
@codspeed

codspeed Bot commented Sep 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 28 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing handoff-flasher-ids (c8693ba) with main (c3bccb8)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (c3bccb8) to head (c8693ba).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2862   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         296      296           
  Lines       25618    25618           
=======================================
  Hits        25556    25556           
  Misses         62       62           
Flag Coverage Δ
py3.12 99.72% <ø> (ø)
py3.14 99.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@esphbot

esphbot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

PR Review — Add the BK72xx flasher id to the hand-off protocol

Merge-ready: this adds bk-uart to the hand-off flasher ids and changes nothing else. No issues found.

What the PR does well:

  • bk-uart is added to the HandoffFlasher union in flasher/src/protocol.ts and matches the id used in the companion frontend PR Hand BK72xx firmware off to web.esphome.io device-builder-frontend#1935.
  • Both doc comments (the per-flasher list and the note on how parts are laid out) now include BK72xx. They correctly class it with the other UF2-as-one-part-at-address-0 flashers, rtl-ambz2 and rp2-picoboot.
  • The change is types and comments only, as the description says. flasher/src/main.ts:30 still sets FLASHERS to ["esp"], so the test page's handshake is unchanged.
  • I searched the code for an exhaustive switch or Record<HandoffFlasher, …> over the union that the new member could break, and found none. The type is only used for flashers?: HandoffFlasher[], flasher?: HandoffFlasher and the FLASHERS constant.

No issues need attention.



Checklist

  • No hardcoded secrets
  • Backward-compatible protocol change (additive union member only)
  • No exhaustive switch/Record over HandoffFlasher broken by the new member
  • Diff matches PR description (types and comments only)

Automated review by Kōan (Claude) HEAD=c8693ba 13s

@esphbot esphbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

No blocking issues found — ready to merge.

@bdraco
bdraco marked this pull request as ready for review September 28, 2026 07:59
Copilot AI lite review requested due to automatic review settings September 28, 2026 07:59
@bdraco
bdraco merged commit 0c850f4 into main Sep 28, 2026
31 checks passed
@bdraco
bdraco deleted the handoff-flasher-ids branch September 28, 2026 08:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review comments; the change is limited to protocol types and documentation.

Review effort: Lite
Findings: None

What changed in this PR

Adds the bk-uart flasher identifier to the BK72xx hand-off protocol.

Changes:

  • Extends HandoffFlasher with bk-uart.
  • Documents BK72xx UF2 hand-off behavior.
File Summary
flasher/​src/​protocol.ts Adds and documents the BK72xx flasher identifier.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants