Skip to content

Add the Pico flasher id to the hand-off protocol - #2859

Merged
bdraco merged 1 commit into
mainfrom
flasher-rp2-picoboot-id
Sep 27, 2026
Merged

bdraco merged 1 commit into
mainfrom
flasher-rp2-picoboot-id

Conversation

@bdraco

@bdraco bdraco commented Sep 27, 2026

Copy link
Copy Markdown
Member

What does this implement/fix?

Adds rp2-picoboot to the hand off flasher ids in flasher/src/protocol.ts, which mirrors the frontend contract. The flasher page here still lists only esp, so nothing else changes.

Related issue or feature (if applicable):

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — docs
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Frontend coordination

Checklist

  • The code change is tested and works locally.
  • Pre-commit hooks pass (ruff, codespell, yaml/json/python checks).
  • Tests have been added or updated under tests/ where applicable.
  • components.index.json / definitions/components/*.json have not been hand-edited (regenerate via script/sync_components.py if a sync is needed).
  • Architecture-level changes are reflected in docs/ARCHITECTURE.md and/or docs/API.md.

@bdraco

bdraco commented Sep 27, 2026

Copy link
Copy Markdown
Member Author

@esphbot review

@github-actions github-actions Bot added the maintenance Maintenance / chores label Sep 27, 2026
@codspeed

codspeed Bot commented Sep 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 28 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing flasher-rp2-picoboot-id (f110077) with main (594bdec)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@esphbot

esphbot commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

PR Review — Add the Pico flasher id to the hand-off protocol

Merge-ready. This is a small, contract-only change and I found no issues.

What the PR does well:

  • It widens the HandoffFlasher union in flasher/src/protocol.ts:83 without changing any behaviour. flasher/src/main.ts:30 still sets FLASHERS to ["esp"] only, so this receiver keeps advertising esp alone.
  • A frame that carries rp2-picoboot is still refused up front by the allowlist check at main.ts:198-200. That matches the PR description.
  • There is no exhaustive switch on HandoffFlasher anywhere in flasher/src, so the wider union cannot break type-checking.
  • The comment updates follow the existing pattern. The one-part-UF2-at-address-0 note now covers both UF2 flashers, and the note that ids are named after the flasher rather than the platform is kept.

No findings.



Checklist

  • No hardcoded secrets
  • Backward-compatible protocol change (additive union member, receiver allowlist unchanged)
  • PR description matches diff

Automated review by Kōan (Claude) HEAD=f110077 11s

@codecov

codecov Bot commented Sep 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (594bdec) to head (f110077).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2859   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files         296      296           
  Lines       25618    25618           
=======================================
  Hits        25556    25556           
  Misses         62       62           
Flag Coverage Δ
py3.12 99.72% <ø> (+<0.01%) ⬆️
py3.14 99.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@esphbot esphbot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

No blocking issues found — ready to merge.

@bdraco
bdraco marked this pull request as ready for review September 27, 2026 22:37
Copilot AI lite review requested due to automatic review settings September 27, 2026 22:37
@bdraco
bdraco merged commit 1c82317 into main Sep 27, 2026
27 checks passed
@bdraco
bdraco deleted the flasher-rp2-picoboot-id branch September 27, 2026 22:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Adds the rp2-picoboot identifier to the flasher hand-off protocol, aligning it with the frontend contract.

Changes:

  • Extends HandoffFlasher with rp2-picoboot.
  • Documents RP2040 UF2 hand-off behavior.
File Description
flasher/​src/​protocol.ts Adds and documents the Pico hand-off flasher ID.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

maintenance Maintenance / chores

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants