Repository navigation
GEI-13: Conflict report as the ship artifact - #14
Merged
Merged
Conversation
Library conflict_report / build_conflict_report groups advisory assessments by CVE and surfaces contradicted (and related weakly_corroborated) groups for affected_range / patched_in / exploit_status with each side's bounded quote_span and source_record_kind/doc. ClaimView carries cite_quote_span. CLI conflict-report display-sanitizes via _ansi_safe. Never auto-resolves. Offline goldens assert runc/Jenkins/OpenSSH conflicts with quote spans.
erxxc
commented
Sep 9, 2026
erxxc
left a comment
Owner
Author
There was a problem hiding this comment.
COMMENT APPROVE — GEI-13 / PR 14 tip fef482d (Review)
GitHub blocks formal APPROVE on own-author token. Review verdict: APPROVE.
Focus holds
- Ship artifact, not a feed:
ConflictReport/build_conflict_report/conflict_report— per-CVE groups only; docstring + CLI help state it is not a CVE feed. - Per-CVE focus classes:
affected_range/patched_in/exploit_statuswithcontradicted+weakly_corroborated; empty CVE excluded. - Quote spans:
bound_quote_span≤ 2000 (matchescite_quote_spanCHECK); CLI display path runs_ansi_safeon CVE/class/entity/set_relation/confidence/doc/kind/quote.ClaimSide.to_dictomitsworkaround_text. - Never auto-resolve: every assessment member →
ClaimSide;favored_tierdisplay-only; golden assertslen(sides)==2for runc/Jenkins/OpenSSH. - Hermetic goldens:
tests/test_gei13_conflict_report.py— replay extract, no network. Diff touches only analyze/cli/db ClaimView/tests — noextract_advisory_v1.md, no fetch policy. - Foundry
reportpath left intact.
Must-fix
None.
Track (non-blocking)
- CLI
flags={g.flags}not per-element_ansi_safe(same pattern as existingreport). Flags are engine-fixed today; keep that invariant. test_cli_conflict_report_ansi_safeonly hits--help+ unit_ansi_safe— does not assertconflict-reportstdout under dirty quotes. Strengthen when convenient.- Library
to_dictquote_span is bounded, not sanitized — intentional (terminal vs web sink); document for consumers.
Independent runtime verify
Review did not re-run uv run pytest -m "not live". Engineering claims 245 / 4 deselected. CoS: please paste independent result on tip fef482d before merge.
Do not ping Eric.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
conflict_report/build_conflict_report): groups advisory assessments by CVE and surfaces contradicted (and related weakly_corroborated) groups foraffected_range/patched_in/exploit_statuswith each side's bounded quote_span + source_record_kind/doc — never auto-resolves.ClaimView/get_claims_for_analysisnow carrycite_quote_span; CLIconflict-reportdisplay-sanitizes all adversary-influenced strings via_ansi_safe. Quote spans bounded to schema max 2000.tests/test_gei13_conflict_report.py) assert runc subset affected_range, Jenkins CNA/CPE, OpenSSH patched_in appear with quote spans. Foundryreportpath unchanged.Test plan
uv run pytest -m "not live"— 245 passed, 4 deselectedtests/test_gei13_conflict_report.py+ GEI-9 goldens greenLinear: GEI-13