fix(erxes): document executor graphql concurrency limits - #24
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the prompt-only Executor documentation to prevent GraphQL page-fetch overload by prescribing bounded concurrency, sequential paging, totalCount-first queries, and partial-result handling. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
7a4df34 to
9ca67a9
Compare
ded9f2b to
c14a43b
Compare
Single source in workshop-shared for pagination/concurrency/discovery guidance. Cap in-flight Executor MCP calls per chat, limit executorDescribe per turn, inject INSTANCE_INSTRUCTIONS on deploy, and fall back when admin config is empty.
Why
Buyanaa's agent hit Executor HTTP 500 from parallel GraphQL storms and wasted steps on
page/perPagepagination. PR #27 fixed empty tool output; this PR adds erxes guardrails with runtime enforcement.Scope
packages/workshop-shared/src/erxes-executor-guidance.ts— single source for pagination, concurrency, discovery budget, instance instructionspackages/workshop-backend/src/overseer.ts— per-chat Executor MCP semaphore (max 5 in-flight)packages/workshop-backend/src/agent.ts—executorDescribecapped at 3/turn; tool descriptions from shared guidancescripts/deploy-instance.ts— injectsINSTANCE_INSTRUCTIONSenv var from shared textpackages/gatekeeper-erxes/src/erxes.ts—EXECUTOR_TYPESfrom shared guidanceVerification
bunx vitest run __tests__/executor-tools.test.ts(includes semaphore test)Test plan
Summary by Sourcery
Add end-to-end erxes Executor guidance and concurrency guardrails to prevent overloaded GraphQL sessions and improve reliable pagination.
New Features:
Bug Fixes:
Enhancements:
Deployment:
Documentation:
Tests: