Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/test_msr_encoding.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,13 @@ def test_package_power_limit_encoder_rejects_field_spill(self):
)
with self.assertRaisesRegex(ValueError, 'PL1'):
throttled._encode_pkg_power_limit(0x8000, 0, 1, 0)
with self.assertRaisesRegex(ValueError, 'PL1 must be at least one power-unit tick'):
throttled._encode_pkg_power_limit(0, 0, 1, 0)
with self.assertRaisesRegex(ValueError, 'PL2'):
throttled._encode_pkg_power_limit(1, 0, 0x8000, 0)
with self.assertRaisesRegex(ValueError, 'PL2 must be at least one power-unit tick'):
throttled._encode_pkg_power_limit(1, 0, 0, 0)
throttled._encode_pkg_power_limit(1, 0, 1, 0)

def test_calculated_package_power_limit_rejects_unencodable_wattage(self):
throttled = load_throttled()
Expand Down
2 changes: 2 additions & 0 deletions throttled.py
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,8 @@ def _encode_pkg_power_limit(pl1, tw1, pl2, tw2):
for name, value, mask in fields:
if not isinstance(value, int) or not 0 <= value <= mask:
raise ValueError(f'{name:s} value {value!r} does not fit its {mask.bit_length():d}-bit field.')
if name in ('PL1', 'PL2') and value == 0:
raise ValueError(f'{name:s} must be at least one power-unit tick, got {value!r}.')
encoded[name] = value
return (
encoded['PL1']
Expand Down