Skip to content

Compatibility with ggplot2 4.0.0 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teunbrand wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compatibility with ggplot2 4.0.0 #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d425ade
contingency plan
teunbrand Jun 18, 2025
58ed08b
ditto for `GeomHalfPointPanel`
teunbrand Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion R/geom_half_point.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,13 @@ GeomHalfPoint <- ggproto(
# ggplot2::resolution(data$point_y[[1]], zero = FALSE) * 0.4
# }

if (is(transformation, "PositionIdentity") || is(transformation, "PositionJitter")) {
# Practical test if ggplot2 is at version 4.x.x+
ggplot2_version_400 <- "class_ggplot" %in% getNamespaceExports("ggplot2")

if (
is(transformation, "PositionIdentity") ||
(is(transformation, "PositionJitter") && !ggplot2_version_400)
) {
trans_positions <- transformation$compute_layer(
transformation_df,
transformation_params_new
Expand Down
8 changes: 7 additions & 1 deletion R/geom_half_point_panel.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,13 @@ GeomHalfPointPanel <- ggproto(
ggplot2::resolution(data$y, zero = FALSE) * 0.4
}

if (is(transformation, "PositionIdentity") || is(transformation, "PositionJitter")) {
# Practical test if ggplot2 is at version 4.x.x+
ggplot2_version_400 <- "class_ggplot" %in% getNamespaceExports("ggplot2")

if (
is(transformation, "PositionIdentity") ||
(is(transformation, "PositionJitter") && !ggplot2_version_400)
) {
trans_positions <- transformation$compute_layer(
transformation_df,
transformation_params
Expand Down