Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ jobs:
path: publish/win-x64/

- name: Sign Windows build
uses: signpath/github-action-submit-signing-request@v2
uses: signpath/github-action-submit-signing-request@v3

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3 changes the default connector-url — this is the only behavior change v2→v3 (everything else in the diff is log-string cosmetics and the taskVersion bump).

  • v2 default: https://githubactions.connectors.signpath.io
  • v3 default: https://pipelineconnector.connectors.signpath.io/GitHubActions/GitHubCom

This step doesn't set connector-url, so the action will start posting to the Pipeline Connector endpoint. If the PerformanceStudio SignPath organization / project was set up against the older GitHub Actions connector and hasn't been migrated to the Pipeline Connector, the next release will fail at "Sign Windows build" with a connector error.

Two options:

  1. Confirm in the SignPath portal that the Pipeline Connector is configured for this org and the release-signing policy, then merge as-is.
  2. Pin the old endpoint explicitly during migration by adding connector-url: 'https://githubactions.connectors.signpath.io' to with:, and drop the pin once migrated.

Ref: v2/v3 action.yml diff, signpath/github-action-submit-signing-request — the connector-url default: line is the only functional change.


Generated by Claude Code

with:
api-token: '${{ secrets.SIGNPATH_API_TOKEN }}'
organization-id: '7969f8b6-d946-4a74-9bac-a55856d8b8e0'
Expand Down
Loading