Tests: the two-rotation log-tail test allows PostgreSQL 18's repeated lock-wait line - #4919
Merged
Merged
Conversation
… lock-wait line, and still requires each line once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
On #4909's CI run (Darling PG tests (2), run
36900036522),PgLogBurstAndRotationLiveTests.TwoRotationsInOneInterval_FinishTheMarkedFile_ReadTheNewestAndCountTheSkippedOnefailed atAssert.Equal(1, WaitCount(cycle.Rows, pidA)): expected 1, actual 2. #4909 changes the blocking and deadlock read windows and doesn't touch the server-log tail or this test.Why
WaitCountcounts a backend's "still waiting" lock-wait lines. PostgreSQL 18 logs that line again when the waiting backend wakes on a latch before the lock is granted, so one wait can leave two or more lines under a loaded runner. The same behaviour made the lock-wait live test flaky before (#4895). The test pinned exactly one line per wait.What changed (tests only)
Testing
Darling.Testsbuilds with 0 warnings and 0 errors.CHANGELOG
None: a test-only change.