Plan viewer: CE model sits above Optimization, and Early abort nests under it, as in PerformanceStudio (#4836) - #4849
Merged
Conversation
…under it, as in PerformanceStudio (#4836)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4836.
Why
PerformanceStudio changed the last rows of its plan Runtime Summary (erikdarlingdata/PerformanceStudio#613, fixed by erikdarlingdata/PerformanceStudio#614). The shared plan viewer here still used the old order, so Lite, the Darling viewer and Studio showed different Runtime Summaries for the same plan.
What changes
PlanDisplayText.BuildRuntimeSummaryRowsnow ends with CE model, then Optimization, then Early abort. It used to end with Optimization, Early abort, then CE model. The doc comment lists the new order.RuntimeSummaryRowgainsNested(default false). The Early abort row is nested only when the Optimization row is present. With no optimization level, it is a plain row.PlanViewerControl.Properties.cs, a nested row's label gets a 12px left margin. Its value keeps the same column as every other value. Lite and the Darling viewer share this control.Test plan
Viewer4570Tests.BuildRuntimeSummaryRows_ActualPlan_OrdersElapsedCpuElapsedDopCpuCompileMemoryCeOptEarlyAbortfails.Viewer4570Tests.BuildRuntimeSummaryRows_EarlyAbortWithOptimizationLevel_IsNestedAndNothingElseIsfails.PlanViewerRuntimeSummaryNestingTests.RuntimeSummary_EarlyAbortUnderOptimization_IndentsItsLabelOnlyfails.BuildRuntimeSummaryRows_EarlyAbortWithoutOptimizationLevel_IsNotNested, and two live-control tests inPlanViewerRuntimeSummaryNestingTests. One checks that the nested label is indented and its value is not. The other checks that Early abort is not indented when there is no Optimization row.CHANGELOG
SECTION: Changed
ENTRY:
REF:
[Plan viewer: CE model sits above Optimization, and Early abort nests under it, as in PerformanceStudio (#4836) #4849]: Plan viewer: CE model sits above Optimization, and Early abort nests under it, as in PerformanceStudio (#4836) #4849