Bump BlackwellSystems.Gcf to 0.2.1 - #2911
Merged
Merged
Conversation
PerformanceStudio took 0.2.1 in erikdarlingdata/PerformanceStudio#501; this puts both repos on the same build rather than leaving Monitor a patch behind on 0.2.0. 0.2.1 is a decoder fix: a quoted key containing "[" alongside an array value now round-trips. Nothing here depended on the broken case. GcfOutput verifies every wire by decoding it and comparing against the input before substituting, so a key that did not round-trip made the result fall back to JSON rather than emit a bad wire -- the bug cost compression on those shapes, never correctness. Only the two Gcf entries are touched. Regenerating the lock with --force-evaluate also pruned unrelated ProtectedData and EventLog entries; those were reverted, since restore --locked-mode (what build.yml runs) accepts the committed lock as it stands and this is a dependency bump, not a lock cleanup. Verified: dotnet restore --locked-mode passes, and Darling.Tests is green at 6901 tests, 0 failed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013nD83xZyWPzKWhs7Gg9Vyq
|
Reviewed. This is a clean, narrowly-scoped dependency bump (
No issues found. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Puts Monitor on the same GCF build PerformanceStudio took in erikdarlingdata/PerformanceStudio#501, instead of leaving it a patch behind on 0.2.0.
What 0.2.1 changes
A decoder fix: a quoted key containing
[alongside an array value now round-trips.Nothing here depended on the broken case, and it was never a correctness risk.
GcfOutputdecodes every wire and compares it against the input before substituting, so a key that failed to round-trip made the result fall back to JSON rather than emit a bad wire. The bug cost compression on those shapes; it could not corrupt one.Scope
Only the two Gcf entries move. Regenerating the lock with
--force-evaluatealso pruned unrelatedSystem.Security.Cryptography.ProtectedDataandSystem.Diagnostics.EventLogentries across two lock files; that churn was reverted.dotnet restore --locked-mode(whatbuild.yml:286runs) accepts the committed lock as it stands, so there is nothing stale to clean up here, and a dependency bump is the wrong PR to do it in.Verified
dotnet restore Darling/Darling.Tests/Darling.Tests.csproj --locked-modepasses.dotnet buildclean.dotnet run --project Darling/Darling.Tests(the invocationbuild.yml:332uses): 6901 total, 0 errors, 0 failed, 296 skipped — the skips are the live-Postgres tests that needDARLING_TEST_PG.🤖 Generated with Claude Code
https://claude.ai/code/session_013nD83xZyWPzKWhs7Gg9Vyq