Skip to content

Bump BlackwellSystems.Gcf to 0.2.1 - #2911

Merged
erikdarlingdata merged 1 commit into
devfrom
chore/gcf-0.2.1
Sep 4, 2026
Merged

erikdarlingdata merged 1 commit into
devfrom
chore/gcf-0.2.1

Conversation

@erikdarlingdata

Copy link
Copy Markdown
Owner

Puts Monitor on the same GCF build PerformanceStudio took in erikdarlingdata/PerformanceStudio#501, instead of leaving it a patch behind on 0.2.0.

What 0.2.1 changes

A decoder fix: a quoted key containing [ alongside an array value now round-trips.

Nothing here depended on the broken case, and it was never a correctness risk. GcfOutput decodes every wire and compares it against the input before substituting, so a key that failed to round-trip made the result fall back to JSON rather than emit a bad wire. The bug cost compression on those shapes; it could not corrupt one.

Scope

Only the two Gcf entries move. Regenerating the lock with --force-evaluate also pruned unrelated System.Security.Cryptography.ProtectedData and System.Diagnostics.EventLog entries across two lock files; that churn was reverted. dotnet restore --locked-mode (what build.yml:286 runs) accepts the committed lock as it stands, so there is nothing stale to clean up here, and a dependency bump is the wrong PR to do it in.

Verified

  • dotnet restore Darling/Darling.Tests/Darling.Tests.csproj --locked-mode passes.
  • dotnet build clean.
  • dotnet run --project Darling/Darling.Tests (the invocation build.yml:332 uses): 6901 total, 0 errors, 0 failed, 296 skipped — the skips are the live-Postgres tests that need DARLING_TEST_PG.

🤖 Generated with Claude Code

https://claude.ai/code/session_013nD83xZyWPzKWhs7Gg9Vyq

PerformanceStudio took 0.2.1 in erikdarlingdata/PerformanceStudio#501; this
puts both repos on the same build rather than leaving Monitor a patch behind
on 0.2.0.

0.2.1 is a decoder fix: a quoted key containing "[" alongside an array value
now round-trips. Nothing here depended on the broken case. GcfOutput verifies
every wire by decoding it and comparing against the input before substituting,
so a key that did not round-trip made the result fall back to JSON rather than
emit a bad wire -- the bug cost compression on those shapes, never correctness.

Only the two Gcf entries are touched. Regenerating the lock with
--force-evaluate also pruned unrelated ProtectedData and EventLog entries;
those were reverted, since restore --locked-mode (what build.yml runs) accepts
the committed lock as it stands and this is a dependency bump, not a lock
cleanup.

Verified: dotnet restore --locked-mode passes, and Darling.Tests is green at
6901 tests, 0 failed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013nD83xZyWPzKWhs7Gg9Vyq
@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown

Reviewed. This is a clean, narrowly-scoped dependency bump (BlackwellSystems.Gcf 0.2.0 → 0.2.1), touching only Directory.Packages.props and Darling/Darling.Tests/packages.lock.json.

  • Scope check: BlackwellSystems.Gcf is referenced only by PerformanceMonitor.Darling.Service.csproj, and the only packages.lock.json in the repo that pins it is Darling/Darling.Tests/packages.lock.json — both are updated consistently, and no other lock file needed touching.
  • Lite/Darling parity: N/A — this package is Darling-only (not referenced anywhere under Lite/), so there's no Lite counterpart to keep in sync.
  • No T-SQL, no application code, no schema/migration changes — none of the style or parity conventions in CONTRIBUTING.md apply here.
  • Correctness/security: version and content hash are updated together and consistently in the lock file; nothing here touches input handling, secrets, or process/network boundaries.

No issues found. LGTM.

@erikdarlingdata
erikdarlingdata merged commit d677518 into dev Sep 4, 2026
6 checks passed
@erikdarlingdata
erikdarlingdata deleted the chore/gcf-0.2.1 branch September 12, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant