Scrub fleet identifiers from main - #2491
Closed
erikdarlingdata wants to merge 1 commit into
Closed
erikdarlingdata wants to merge 1 commit into
erikdarlingdata wants to merge 1 commit into
Conversation
…fault The scrub landed on dev only. main is 221 commits behind it and is the branch anyone browsing this public repo sees first, so the old names are still the ones on display -- including in Darling/README.md and darling.sample.json, which are the files a new user actually reads. Waiting for the release to carry the fix over leaves them up in the meantime, so this is the same rename applied directly to main. Scoped to whole instance names rather than bare tokens, because "apex" is domain vocabulary here -- it is the root of a blocking chain in about fifty files -- and a token-level rename corrupted every one of them on the first attempt. No leading word-boundary assertion either. One name appears as "servers:\nprod-..." where the n of the escape is a word character, so both \b and a negative-lookbehind fail at precisely the spot a hostname does occur. That is the third boundary assumption in this scrub to under-match and report clean. Verified the renamed strings are not load-bearing: both peer match patterns are still contained in the hosts they have to claim, so the disclosure still agrees in number. Darling.Tests and Lite.Tests both build clean. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Closing this —
That gate is release discipline and worth keeping, so this is the wrong instrument. The scrub is already on So this is not a patch decision, it is a release-timing one. Tracking in #2492 rather than leaving a permanently red PR open. The branch is kept in case the content is useful as a cherry-pick during the release. Worth keeping from the attempt, since both were found here and are fixed elsewhere:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed —
check-branchesrefuses it by design ("pull requests to main are only allowed from dev"), and that gate is worth keeping. The branch is retained in case the rename is easier to graft than to re-derive.Two things worth keeping from the attempt, both fixed elsewhere:
apexis domain vocabulary here — the root of a blocking chain. Scoped to whole instance names it is 9 files.nof\nis a word character. The Pin fixture hostnames to synthetic slugs #2490 guard had the same flaw and no longer does.