Skip to content

check-version: survive the deprecated/ layout transition on the main side #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Jul 29, 2026
Merged

check-version: survive the deprecated/ layout transition on the main side #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/check-version-bump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,14 @@ jobs:
id: main
shell: pwsh
run: |
$version = ([xml](Get-Content main-branch/deprecated/Dashboard/Dashboard.csproj)).Project.PropertyGroup.Version | Where-Object { $_ }
# main still carries the pre-deprecation layout until the v3.3.0 promotion lands;
# fall back to the old path so the release PR itself can pass. Removable once
# main has deprecated/Dashboard/.
$path = 'main-branch/deprecated/Dashboard/Dashboard.csproj'
if (-not (Test-Path $path)) { $path = 'main-branch/Dashboard/Dashboard.csproj' }
$version = ([xml](Get-Content $path)).Project.PropertyGroup.Version | Where-Object { $_ }
echo "VERSION=$version" >> $env:GITHUB_OUTPUT
Write-Host "Main version: $version"
Write-Host "Main version: $version (from $path)"

- name: Compare versions
if: steps.changes.outputs.all_count != steps.changes.outputs.docs_count
Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- **CI: the version-bump check survives the deprecated/ layout transition** ([#1821]) - the check compares the PR's Dashboard.csproj version against MAIN's copy, but read main's copy only at the NEW deprecated/ path - which does not exist on main until the v3.3.0 promotion itself lands, so the release PR failed the check on a path error rather than a version verdict. The main-side read now falls back to the pre-move location; removable once main carries the new layout.

## [3.3.0] - 2026-07-29

### Important
Expand Down Expand Up @@ -1906,6 +1910,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#1665]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/1665
[#1799]: https://github.com/erikdarlingdata/PerformanceMonitor/pull/1799
[#1798]: https://github.com/erikdarlingdata/PerformanceMonitor/issues/1798
[#1821]: https://github.com/erikdarlingdata/PerformanceMonitor/pull/1821
[#1797]: https://github.com/erikdarlingdata/PerformanceMonitor/pull/1797
[#1788]: https://github.com/erikdarlingdata/PerformanceMonitor/pull/1788
[#1781]: https://github.com/erikdarlingdata/PerformanceMonitor/pull/1781
Expand Down
Loading