test(oracle): dump the furthest-progressing attempt on statelessreset-client failure - #82
Merged
Merged
Conversation
…-client failure Follow-up nit from the #79 review. On final failure the retry loop dumped `try$attempts` (the last attempt) unconditionally, so a late attempt that failed early — e.g. a bind race (rank 1) — would hide an earlier attempt that ran the whole sequence and missed the reset (rank 5), which is the informative one. Track each attempt's stage rank via a small `note RANK REASON` helper and dump the furthest-progressing attempt (ties prefer the later/freshest one). Verified: the selection logic picks the latest rank-5 attempt over an earlier one and ignores a later low-rank failure; fault injection (no reset ever sent) still fails red after 3 attempts and now reports 'debug (furthest attempt: .../try3)'. Full matrix 78/78.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final follow-up nit from the #79 review.
Problem
On final failure the retry loop dumped
try$attempts(the last attempt) unconditionally. If a late attempt failed early (e.g. a bind race, rank 1) while an earlier one ran the whole sequence and missed the reset (rank 5 — the informative case), the debug showed the least useful attempt.Fix
A small
note RANK REASONhelper records each attempt's stage rank (1 = phase-1 bind … 5 = ran to the[SRST]check) and remembers the furthest-progressing attempt's dir; ties prefer the later/freshest attempt. The failure dump uses that dir.Verification
debug (furthest attempt: .../try3).statelessreset-clientgreen; self-test 15/15; full matrix 78/78.Harness-only (
oracle/run.sh).