fix: correct alacritty executable name in terminal detection (allacrity → alacritty)

[Jah-yee]

Summary

Fix DevcontainerConnect terminal detection when using alacritty as the terminal emulator.

Root cause

In lua/devcontainer-cli/devcontainer_utils.lua line 238, the vim.fn.executable() check incorrectly used allacrity instead of alacritty:

- elseif vim.fn.executable("allacrity") == 1 then
+ elseif vim.fn.executable("alacritty") == 1 then

This caused the terminal detection to fall through to the "no supported terminal emulator found" branch, making DevcontainerConnect silently fail (Neovim closes but no alacritty window spawns).

Fix

1 character change: allacrity → alacritty.

Testing

vim.fn.executable("alacritty") now correctly returns 1 when alacritty is installed, allowing the proper terminal detection branch to execute.

Related

Fixes #31

Summary by CodeRabbit

Bug Fixes

• Resolved terminal emulator detection issue by correcting the Alacritty executable identifier. This fix ensures proper terminal command routing when establishing connections from Neovim in the devcontainer workflow.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea6b1231-bf85-480f-94c9-41d6072471c3

📥 Commits

Reviewing files that changed from the base of the PR and between a92bae8 and a56df49.

📒 Files selected for processing (1)

• lua/devcontainer-cli/devcontainer_utils.lua

---

📝 Walkthrough

Walkthrough

Fixed a typo in the Alacritty terminal emulator detection logic within create_connect_cmd(). The executable check previously searched for "allacrity" instead of "alacritty", causing terminal detection to fail when connecting to a devcontainer from Neovim using Alacritty.

Changes

Terminal Emulator Detection

Layer / File(s)	Summary
Alacritty executable detection lua/devcontainer-cli/devcontainer_utils.lua	Corrected the misspelled vim.fn.executable("allacrity") to vim.fn.executable("alacritty") so terminal selection properly detects the Alacritty emulator when constructing the connection command.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🐰 A typo once broke our terminal flow,
When Alacritty would never quite go,
But now with the fix, both letters align,
Windows spawn swift—the connection's divine! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: correcting the typo from 'allacrity' to 'alacritty' in terminal detection logic, which is the sole modification in this changeset.
Linked Issues check	✅ Passed	The PR directly addresses the root cause identified in issue #31 by correcting the executable name from 'allacrity' to 'alacritty', enabling proper Alacritty terminal detection for DevcontainerConnect.
Out of Scope Changes check	✅ Passed	The PR contains only the targeted one-character typo fix in the terminal detection logic, with no unrelated or out-of-scope modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}