⚡ Bolt: Optimize globals scope tracking lookup - #126
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added a
globalNameshash map to optimize the O(N) global variable presence check withinattachScope.🎯 Why: In
luaparse.js,indexOfObject(globals, 'name', node.name)was executing sequentially on an array for every global identifier in a linear lookup when collecting scope, causing unnecessary overhead for larger source files.📊 Impact: Transforms a linear O(N) lookup within the scope parsing process to a constant time O(1) hash map check, noticeably improving parsing performance for large scopes.
🔬 Measurement: Verified the improvement with
npm run bench:luastalongside all tests vianpm run testsuccessfully.PR created automatically by Jules for task 6170070596600731658 started by @ericbfriday