Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1406 commits
Select commit Hold shift + click to select a range
9e1bae6
Merge remote-tracking branch 'origin/gitlab/update-matrix-modules' in…
debog Apr 27, 2026
3d9e4fc
added inputs for 3D bubble with AMR
debog Apr 27, 2026
ad87252
added 3D SDM+AMR tests
debog Apr 27, 2026
93b1064
Mask covered coarse cells in phaseChange and Copy_Micro_to_State
debog Apr 29, 2026
cac729b
Add AverageDownMicroVars and RestoreMoistVarsInState_Lev for SDM+AMR …
debog Apr 29, 2026
2326380
Pre-regrid sync of moisture state for SDM+AMR in TwoWay coupling
debog Apr 29, 2026
b3a507f
Plotfile sync of moisture state for SDM+AMR in TwoWay coupling
debog Apr 29, 2026
3a63022
Replace RestoreMoistVarsInState_Lev with conservation-preserving amre…
debog Apr 29, 2026
30ba7b5
Scale coalescence bins by refRatio per level to keep physical bin vol…
debog Apr 29, 2026
91924a6
Use ERF::AverageDownTo (with do_perturbational_and_momenta=false) for…
debog Apr 29, 2026
4bc8f06
Build fine_mask with mic-fab ghost width to avoid OOB on grown iterat…
debog Apr 29, 2026
5935645
Read qc and qr from state in Copy_State_to_Micro for q_t consistency …
debog Apr 29, 2026
6e7cc50
Recompute qc from particles before computing qt in phaseChange for co…
debog Apr 29, 2026
61e5cee
Reset idata(k) to finest-level k before each full Redistribute in Fix…
debog Apr 29, 2026
7c63777
update gcc and cuda modules
gardner48 Apr 27, 2026
bda0c05
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_AMR
debog Apr 29, 2026
70c73cf
Merge remote-tracking branch 'origin/gitlab/update-matrix-modules' in…
debog Apr 29, 2026
1787199
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_cold…
debog Apr 29, 2026
126b5b6
Merge remote-tracking branch 'origin/gitlab/update-matrix-modules' in…
debog Apr 29, 2026
5e20f1c
Use fab z-extent as additional bound on zface stencil access in depos…
debog Apr 29, 2026
b0fccd2
Skip particles in MassChange whose idata_k stencil falls outside loca…
debog Apr 29, 2026
0b09fcb
Tighten MassChange stencil-bound skip to pk+2 to match cic_interpolat…
debog Apr 30, 2026
be7dc43
Add idata(k_finest) slot so multi-level Redistribute Assignor places …
debog Apr 30, 2026
2f74914
Move s_dxi_z_finest from class member to namespace scope so AMREX_GPU…
debog Apr 30, 2026
2c9f60b
Sync cons[lev-1] covered cells from cons[lev] after each level's adva…
debog May 1, 2026
42838fb
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_AMR
debog May 1, 2026
8b29da3
Fix SDM MoistureComponentIndices: pass explicit -1 for qi so RhoQ3 (r…
debog May 1, 2026
5fd1959
Merge branch 'fix_SDM_moist_index' into dg/sdm_w_AMR
debog May 1, 2026
4f6b1ef
Extend tagging field_name to all moisture mixing ratios (qv/qc/qi/qr/…
debog May 1, 2026
a78a4fe
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_AMR
debog May 6, 2026
efb9738
Foundation: add ERF_TerrainConversion.H with z<->zeta utilities, terr…
debog May 7, 2026
158ff28
Flip particle pos(2) convention to computational zeta: Assignor inlin…
debog May 7, 2026
3788457
Restore per-level Redistribute pattern in EvolveParticles to prevent …
debog May 7, 2026
6d2eeb0
Particles: terrain advection metric and plotfile pos->physical conver…
debog May 7, 2026
5f548c2
Particles: round-trip integration in physical z for terrain advection
debog May 7, 2026
6949fc8
SDM recycle: wrap deactivated-particle dump in zeta<->physical-z conv…
debog May 7, 2026
041798a
SDM recycle: place recycled particles in physical (x,y,z), then map z…
debog May 7, 2026
96593a6
ParticleWoA gold: regenerate for computational-zeta particle conventi…
debog May 7, 2026
1de10e6
temporarily chaning gold file branch for CI [run-ci]
debog May 7, 2026
9d2ea88
Particles: drop dead AoS structs, dead helpers, no-op stubs; rename S…
debog May 7, 2026
06749c2
Merge branch 'development' into dg/particles_w_terrain_refactor
debog May 7, 2026
a48a8cd
Revert "temporarily chaning gold file branch for CI [run-ci]"
debog May 7, 2026
d93f4db
Merge dg/particles_w_terrain_refactor into dg/sdm_w_AMR
debog May 7, 2026
34f59e9
Merge branch 'dg/particles_w_terrain_refactor' into dg/sdm_w_AMR
debog May 7, 2026
31f147e
Merge erfrepo/development into dg/sdm_w_AMR
debog May 8, 2026
2d1cdb7
Tagging: support refinement on Eulerian mesh variables provided by pa…
debog May 8, 2026
e446ddc
Merge branch 'dg/sdm_w_AMR' into dg/sdm_w_cold_processes
debog May 8, 2026
3ee7ab3
Merge erfrepo/development into dg/sdm_w_cold_processes
debog May 20, 2026
af0abd6
adding DYCOMS test cases
May 20, 2026
29d9fb8
Fix SP-mesh and SP-particle build errors in cold-process code
debog May 20, 2026
02303b8
Merge origin/dg/sdm_w_cold_processes: DYCOMS test cases
debog May 20, 2026
d0d1a7b
Clean up DYCOMS prob code: drop unused variables, consolidate duplica…
debog May 21, 2026
47925cc
updated input file for DYCOMS2RF01
May 21, 2026
2e96049
Merge branch 'dg/sdm_w_cold_processes' of ssh://czgitlab.llnl.gov:799…
May 21, 2026
4b6645f
Fix Clang DP-mesh/SP-particle narrowing errors in functor brace-initi…
debog May 21, 2026
5a67179
removed commented-out lines from input
debog May 21, 2026
cdefdb3
Remove unused custom rhotheta/moisture forcing flags from DYCOMS2RF01…
debog May 21, 2026
e794aaf
Merge branch 'development' into dg/sdm_w_cold_processes
debog May 21, 2026
21ad6b1
removed code quality report
debog May 21, 2026
1cf74d3
Merge remote-tracking branch 'origin/dg/sdm_w_cold_processes' into dg…
debog May 22, 2026
0c8eaf3
Recompute particle condensate before forming qt in each phaseChange r…
debog May 22, 2026
deab555
Conform incidental SDM diffs against development: restore Gpu::synchr…
debog May 22, 2026
1987181
Regenerate SDM_MoistBubble{2D_AMR1,3D_AMR1,3D_AMR2} gold files for th…
debog May 23, 2026
1a5cf57
Add split/merge AMR API stubs + flag + Redistribute hook
debog May 26, 2026
a354d8a
Implement SplitMergeAtLevelBoundary: 3-part split-new/merge-departees…
debog May 27, 2026
26d9ff3
Implement SplitParticlesForRefinement (regrid-time): split coarse par…
debog May 27, 2026
f8899e8
Implement MergeParticlesAfterDerefining (regrid-time): masked merge i…
debog May 27, 2026
2c020b4
Wire SplitParticlesForRefinement / MergeParticlesAfterDerefining into…
debog May 27, 2026
e59e243
Use SuperDropletsRealIdx/IntIdx (dev names) instead of stale SoA aliases
debog May 27, 2026
ec9b938
Skip refRatio scaling of coalescence bins when split/merge AMR is on …
debog May 27, 2026
6c2a4f4
Normalize active flag to 0/1 when used as a count weight in depositio…
debog May 27, 2026
215b705
Merge branch 'dg/AMR_w_par_split' into dg/sdm_w_cold_processes
debog May 27, 2026
ed55567
Generalize SDM split-merge tag to level+1 (Phase 1 of multi-level red…
debog May 27, 2026
cef843b
Cumulative finest-level split in SplitParticlesForRefinement (Phase 2)
debog May 27, 2026
6079b7d
Fold MergeParticlesAfterDerefining into per-level tag-normalizing swe…
debog May 28, 2026
91633d4
Resync particle container dummy MFs at start of SplitParticlesForRefi…
debog May 28, 2026
b8e3504
Redistribute particles before SDM regrid-time split; iterate leaf lev…
debog May 28, 2026
2ccbf5b
Restrict SDM Part 3 empty-cell repopulation to same coarse parent to …
debog May 28, 2026
304ac1c
Merge remote-tracking branch 'origin/dg/AMR_w_par_split' into dg/sdm_…
debog May 28, 2026
200c6d0
Add ventilation factor (Bayley et al. 2025) to SDM condensation/evapo…
debog May 28, 2026
5cfc69e
Revert per-level Part 2 no-host branch to retag-only to fix evaporati…
debog May 28, 2026
a5b03e4
Merge remote-tracking branch 'origin/dg/AMR_w_par_split' into dg/sdm_…
debog May 29, 2026
da9781f
Add MergeParticlesAtDerefinement regrid-time pass to reduce np_bin to…
debog May 29, 2026
32f61e0
Merge remote-tracking branch 'origin/dg/AMR_w_par_split' into dg/sdm_…
debog May 29, 2026
ea6e63a
Merge remote-tracking branch 'erfrepo/development' into dg/AMR_w_par_…
debog May 29, 2026
9404e3f
WIP: gradual SDM ice melting (Seifert-Beheng 2006 rate) with mixed ic…
debog May 29, 2026
9d9b61c
Merge remote-tracking branch 'origin/dg/AMR_w_par_split' into dg/sdm_…
debog May 29, 2026
fcb0a60
Merge remote-tracking branch 'origin/dg/sdm_w_cold_processes' into dg…
debog May 29, 2026
c6418ad
Add SDM_Box3D_IceMelt regression test seeding pure ice in a warm box …
debog May 30, 2026
19a4db6
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_w_…
debog Jun 2, 2026
71cf1ed
Merge remote-tracking branch 'origin/llnl/development' into dg/AMR_w_…
debog Jun 2, 2026
18000ea
Merge branch 'dg/AMR_w_par_split' into dg/sdm_w_cold_processes
debog Jun 2, 2026
96aadfc
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting [run…
debog Jun 2, 2026
a841ac8
Restrict SDM AMR merges to same log-radius bin (per-cell adaptive ran…
debog Jun 3, 2026
5870440
Merge remote-tracking branch 'origin/llnl/development' into dg/AMR_w_…
debog Jun 4, 2026
447542a
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_ph…
debog Jun 4, 2026
acc76e7
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_w_…
debog Jun 4, 2026
08eabdd
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_ic…
debog Jun 4, 2026
f7e4b0a
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting
debog Jun 4, 2026
81ecd69
Merge branch 'dg/sdm_phase_change_ventilation' into dg/sdm_w_cold_pro…
debog Jun 4, 2026
6748f8f
Merge remote-tracking branch 'origin/llnl/development' into dg/AMR_w_…
debog Jun 4, 2026
df1b375
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting [run…
debog Jun 4, 2026
346f2e2
Add multiplicity floor to per-step SplitMergeAtLevelBoundary Part 1 s…
debog Jun 5, 2026
e3f6fe6
Integer multiplicity split at both SDM split sites: each piece gets f…
debog Jun 5, 2026
6220057
Merge remote-tracking branch 'origin/llnl/development' into dg/AMR_w_…
debog Jun 10, 2026
317d0c1
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_w_…
debog Jun 10, 2026
4e68178
Merge branch 'dg/AMR_w_par_split' into dg/sdm_w_cold_processes
debog Jun 10, 2026
bb5087a
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting [run…
debog Jun 10, 2026
5c0fa9d
Merge remote-tracking branch 'origin/llnl/development' into dg/AMR_w_…
debog Jun 11, 2026
caa58a5
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_w_…
debog Jun 11, 2026
16bf3a6
Fix missing PlaneAverage include in ERF_AdvanceDycore.cpp
debog Jun 12, 2026
fa51ca5
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting [run…
debog Jun 12, 2026
54ceccb
Merge branch 'dg/AMR_w_par_split' into dg/sdm_w_cold_processes
debog Jun 12, 2026
3b1fd6d
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting [run…
debog Jun 12, 2026
3226b06
Merge branch 'llnl/development' into dg/AMR_w_par_split [run-ci]
debog Jun 16, 2026
bd55de8
Merge branch 'llnl/development' into dg/sdm_w_cold_processes
debog Jun 16, 2026
88ac2a8
Merge branch 'dg/AMR_w_par_split' into dg/sdm_w_cold_processes
debog Jun 16, 2026
fb8eed2
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_ice_w_melting [run…
debog Jun 16, 2026
00174d5
using std::ceil for density scaling of multiplicities to avoid non-in…
debog Jun 18, 2026
b2a0e5d
Implemented Gunn-Kinzer clamp on vterm calculation
debog Jun 18, 2026
cc19861
Bound wet/mixed-ice terminal velocity: blend Boehm dry-ice speed towa…
debog Jun 18, 2026
cf1140f
updated gold files
debog Jun 18, 2026
bf12d52
Update SDM theory docs: gradual melting and mixed ice-water particles…
debog Jun 18, 2026
983db7f
Add terminal-velocity unit tests (Gunn-Kinzer clamp, Bohm ice vs Boeh…
debog Jun 18, 2026
fe7fdfc
Allow seeded/injected ice particles to take a prescribed apparent den…
debog Jun 18, 2026
a68610d
Add ice deposition-growth unit test (Chen-Lamb habit vs Takahashi 199…
debog Jun 19, 2026
1b21d65
TerminalVelocity gtest: add EvalFromCsv mode (CSV-driven, phase-route…
debog Jun 19, 2026
b9b6e3d
SDM sublimation: release a fully-sublimated ice core back to a dry ae…
debog Jun 19, 2026
482cc31
SDM freezing: if the freezing water is below the minimum ice mass (an…
debog Jun 19, 2026
94d0e62
SDM IceFrzDep test: seed resolvable droplet water so freezing yields …
debog Jun 19, 2026
c844a27
SDM MultiSpecies gold: regenerate after the trace-water-to-aerosol ch…
debog Jun 19, 2026
0b4471f
Merge branch 'development' into most_walls_dev_sdm_new
ckendrick Jun 22, 2026
5388031
SDM SV habit table: function-local static constexpr for host+device
debog Jun 22, 2026
4838526
Fixed precision-related errors and warnings
debog Jun 23, 2026
0110c7c
Bugfix: visc coeff needs to be converted to SI units
debog Jun 23, 2026
01210b5
TerminalVelocity test: recenter graupel band, add Stokes-regime check
debog Jun 23, 2026
241078f
TerminalVelocity test: dump L-H habit + ice-sphere(+Stokes) curves fo…
debog Jun 24, 2026
2ebb8b0
Updated ice benchmarks
debog Jun 24, 2026
9788b03
Merge remote-tracking branch 'origin/dg/sdm_w_cold_processes' into dg…
debog Jun 24, 2026
58a8c77
Add SDM microphysics unit tests: condensation, melting/sublimation, I…
debog Jun 25, 2026
abbf080
Factor riming helpers into header; add riming unit tests
debog Jun 25, 2026
6922950
Add fractional super-droplet injection with SDM_Bubble2D_FracInjectio…
debog Jun 25, 2026
cb4b060
Clean up branch-unique SDM inputs (DYCOMS/GATE/TempSourceCold); sync …
debog Jun 26, 2026
b645679
SDM: add prescribed_w steady-updraft advection option
debog Jun 26, 2026
f0a0615
Merge remote-tracking branch 'origin/llnl/development' into dg/sdm_w_…
debog Jun 26, 2026
413bc1f
Add SDM ice-process ctests (sublimation/melting/freezing/aggregation/…
debog Jun 26, 2026
880f98d
Add SDM ice-microphysics example inputs and READMEs in Exec
debog Jun 26, 2026
fb87689
Merge remote-tracking branch 'origin/development' into dg/sdm_w_cold_…
debog Jun 26, 2026
19c95db
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_fractional_injecti…
debog Jun 26, 2026
7bfec38
Removing sublimation shaft test for AMD GPUs
debog Jun 29, 2026
c2510ac
Merge branch 'dg/sdm_w_cold_processes' into dg/sdm_fractional_injecti…
debog Jun 29, 2026
9cd00dd
SDM: per-box high-multiplicity injection [run-ci]
debog Jun 29, 2026
83cbc22
Add ice_aggregation_efficiency input for SDM ice-ice aggregation (def…
debog Jul 1, 2026
a9dd7f3
Merge remote-tracking branch 'origin/dg/sdm_w_cold_processes' into dg…
debog Jul 1, 2026
470d8a1
switch kernel velocity terms
emmacware Jul 2, 2026
706cb41
Merge branch 'emma_cold_processes' into 'dg/sdm_w_cold_processes'
debog Jul 2, 2026
aa527fe
Merge remote-tracking branch 'origin/dg/sdm_w_cold_processes' into dg…
debog Jul 2, 2026
4234954
Merge branch 'dg/sdm_w_cold_processes' into most_walls_dev_sdm_new
ckendrick Jul 13, 2026
0599b59
Fix fill boundary issue
ckendrick Jul 13, 2026
7135871
Rebuild FFT solvers on restart
ckendrick Jul 20, 2026
7f577af
Fixed GATE readme
debog Jul 20, 2026
1a19c24
SDM riming: at T>=0C route the collected droplet to meltwater instead…
debog Jul 21, 2026
add9e5f
SDM: allow zero-mass constant aerosols; require at least one non-zero…
debog Jul 22, 2026
82661a5
SDM: add erf.random_seed input to vary the RNG (init sampling + colli…
debog Aug 2, 2026
cfa4928
SDM/particles: fix OOB indexing, div-by-zero, half-step drift, ghost …
debog Aug 10, 2026
8876723
SDM/particles: fix tiled in-place saturation ratio, RNG race, zeta co…
debog Aug 10, 2026
ee1320c
Add OpenMP, ASan, terrain-SDM, tiled and single-rank test coverage fo…
debog Aug 10, 2026
cc228aa
Narrow recycle terrain clamp to the lookup, clamp tail index instead …
debog Aug 10, 2026
2d44102
Add in-repo gold files for SDM_Bubble2D_WoA and SDM_Bubble2D_Tiled [r…
debog Aug 10, 2026
941d530
Merge branch 'development' into fix-SDM-issues
debog Aug 10, 2026
adab515
Merge branch 'development' into fix-SDM-issues
debog Aug 10, 2026
2b7a457
Merge branch 'development' into fix-SDM-issues
debog Aug 10, 2026
67b0e10
Merge branch 'development' into fix-SDM-issues
debog Aug 10, 2026
fa16bdc
Merge branch 'development' into fix-SDM-issues
debog Aug 11, 2026
d2388df
Use ThreadSanitizer for the threaded job; assert the sampled tail ind…
debog Aug 11, 2026
67b8a5d
Merge erfrepo/development into dg/sdm_w_cold_processes
debog Aug 11, 2026
b106ce3
Update RadiationSimple to current IRadiation interface (double time/d…
debog Aug 11, 2026
b6ecd59
Merge fix-SDM-issues into dg/sdm_w_cold_processes; apply the tiling f…
debog Aug 11, 2026
6565655
Restore lsf_data/nudge_data sizing and the RadiationSimple branch los…
debog Aug 11, 2026
135324f
Advertise ice, snow and graupel plot variables for the super-droplet …
debog Aug 11, 2026
449de0d
Drop input keys upstream no longer reads; correct recycle-bounds name…
debog Aug 11, 2026
de31b91
Rename TemperatureSourceSpatial_cold to SDM_Congestus3D_cold to match…
debog Aug 11, 2026
7bd5cb3
Reject a species that is already modeled; drop the duplicate ice entr…
debog Aug 11, 2026
8f18218
Remove local agent config and notes accidentally committed under .claude
debog Aug 11, 2026
115e846
Point LC CI back at the main gold-file ref
debog Aug 11, 2026
1fc587c
Restore SDM_Congestus3D and SDM_RICO3D golds as whole plotfiles; the …
debog Aug 11, 2026
c8d63fd
Strip trailing whitespace from new decks and profile output
debog Aug 11, 2026
d2c1246
Regenerate SDM_SublimationShaft, SDM_Congestus3D and SDM_RICO3D golds…
debog Aug 11, 2026
31b9354
Drop the ThreadSanitizer and AddressSanitizer CI jobs
debog Aug 11, 2026
e1a5f18
Merge branch 'fix-SDM-issues' into dg/sdm_w_cold_processes
debog Aug 11, 2026
438bcf4
Run the gated SDM cases as assertion-checked smoke tests in the GNU b…
debog Aug 11, 2026
bf626c7
Fix single-precision build: keep the injected super-droplet count in …
debog Aug 11, 2026
2375c3b
Leave the coalescence box tests out of the smoke pass; the kernels ha…
debog Aug 11, 2026
749e702
Update the moisture capability truth table for the super-droplet ice …
debog Aug 12, 2026
da82528
Fix single-precision build in the large-scale forcing update; drop an…
debog Aug 12, 2026
d3f78f3
Temporarily point LC CI at the SDM_w_ice gold-file ref
debog Aug 12, 2026
a76f7bb
Revert "Temporarily point LC CI at the SDM_w_ice gold-file ref"
debog Aug 12, 2026
4ad19ec
Rename fo to nbr_off and ofs, and fix a hyphenated word, to satisfy c…
debog Aug 12, 2026
ebaa290
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_cold…
debog Aug 12, 2026
cfd8516
Build the super-droplet microphysics unit tests only when particles a…
debog Aug 12, 2026
30df3c4
Silence unused-parameter, unused-variable and shadow warnings in the …
debog Aug 12, 2026
5a6ca88
Merge branch 'development' into dg/sdm_w_cold_processes
debog Aug 12, 2026
62acb3e
Rename the inner reduction locals so they no longer shadow the Reduce…
debog Aug 12, 2026
ae253fd
Merge branch 'development' into dg/sdm_w_cold_processes
debog Aug 13, 2026
b882bf2
Review fixes: drop duplicate theta nudging, index LSF/nudge data by l…
debog Aug 13, 2026
a083f9e
Review fixes: correct the momentum subsidence gradient and k-range, s…
debog Aug 13, 2026
a1bea80
Review fixes: guard log10 in the riming fit, gate the ghost refresh o…
debog Aug 13, 2026
1700544
Compare against the signed Long returned by amrex::Vector::size()
debog Aug 13, 2026
63623d5
Temporarily point LC CI at the SDM_w_ice gold-file ref
debog Aug 13, 2026
081fb3d
Revert "Temporarily point LC CI at the SDM_w_ice gold-file ref"
debog Aug 13, 2026
91bcea6
Merge remote-tracking branch 'pubrepo/dg/sdm_w_cold_processes' into d…
debog Aug 13, 2026
9039c47
Regenerate in-repo golds for the gated SDM tests and drop the particl…
debog Aug 13, 2026
829f471
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_cold…
debog Aug 13, 2026
9ac7af7
Guard the ice-category active tag, convert erf_esati to Pa for the ri…
debog Aug 13, 2026
107a2a9
Merge branch 'development' into most_walls_dev_sdm_new
ckendrick Aug 13, 2026
4056f04
Regenerate the riming gold and keep the plotfile-selection semantic c…
debog Aug 13, 2026
7455f27
Merge remote-tracking branch 'erfrepo/development' into dg/sdm_w_cold…
debog Aug 13, 2026
ca036f6
Merge branch 'development' into dg/sdm_w_cold_processes
debog Aug 13, 2026
38b8734
Clean up old code
ckendrick Aug 14, 2026
912b45c
Merge branch 'dg/sdm_w_cold_processes' into cloudchamber
ckendrick Aug 14, 2026
515c05d
Update unit test for new diffusion call signature
ckendrick Aug 14, 2026
c831d0f
Fix warning
ckendrick Aug 14, 2026
ab46dbf
Update goldfile branch
ckendrick Aug 14, 2026
a123d19
Cleanup diffusion
ckendrick Aug 14, 2026
2102b69
Remove unused variables
ckendrick Aug 14, 2026
fe1fce0
Update checkpoint names used for single face case
ckendrick Aug 14, 2026
e492639
Update PBL MOST average indices
ckendrick Aug 14, 2026
3049612
Add missing test
ckendrick Aug 15, 2026
7d7f8bc
Turn off FFT option for CI
ckendrick Aug 15, 2026
c570b75
Fix warnings
ckendrick Aug 15, 2026
9575e34
Add gold file for MOST walls test
ckendrick Aug 15, 2026
3841117
Merge branch 'development' into cloudchamber
ckendrick Aug 15, 2026
fa7cadd
Skip test if not built with FFT enabled
ckendrick Aug 15, 2026
0c790aa
Add option for FFT to LC CI and temporarily enable
ckendrick Aug 15, 2026
a37b33b
Style
ckendrick Aug 17, 2026
e36532b
Add doc section for surface layer on sides
ckendrick Aug 17, 2026
910e237
Remove goldfile treated as text
ckendrick Aug 17, 2026
e100771
Readd goldfile as binary
ckendrick Aug 17, 2026
1f0f978
Move LC gitlab goldfile ref back to main
ckendrick Aug 17, 2026
96560ae
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick Aug 17, 2026
ba74318
Fix stress mapping on x face
ckendrick Aug 27, 2026
a3fa17e
Fix review issues
ckendrick Aug 27, 2026
6a0ae28
Minor cleanup for plotfile variables
ckendrick Aug 27, 2026
501c98b
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick Aug 28, 2026
3654395
Update gold files for new changes
ckendrick Aug 28, 2026
fec3daf
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick Aug 28, 2026
fcc67f7
Fix unused warnings
ckendrick Aug 28, 2026
ffa6f2c
Fix extra ghost cells for z face in compute_fluxes
ckendrick Aug 28, 2026
293811a
Fix more unused parameter warnings
ckendrick Aug 29, 2026
909a4a9
Merge remote-tracking branch 'upstream/development' into cloudchamber
ckendrick Aug 29, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
*.H linguist-language=C++
*.h linguist-language=C++
Tests/ERFGoldFiles/ABL_MOST_Cloudchamber/Level_0/Cell_D_* binary
Tests/ERFGoldFiles/ABL_MOST_Cloudchamber/Level_0/Nu_nd_D_* binary
1 change: 1 addition & 0 deletions .gitlab/LC/gitlab_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ time cmake \
-D AMReX_CUDA_ARCH:STRING="${CUDA_ARCH:-""}" \
-D ERF_ENABLE_HIP:BOOL="${ERF_ENABLE_HIP:-"OFF"}" \
-D AMReX_AMD_ARCH:STRING="${AMD_ARCH:-""}" \
-D ERF_ENABLE_FFT:BOOL="${ERF_ENABLE_FFT:-"OFF"}" \
-D ERF_ENABLE_FCOMPARE:BOOL=ON \
-D FCOMPARE_EXE="${FCOMPARE_EXE}" \
-D ERF_ENABLE_DOCUMENTATION:BOOL=OFF \
Expand Down
4 changes: 3 additions & 1 deletion .gitlab/LC/jobs/dane.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,7 @@ dane_gcc_12_1_1:
variables:
RUN_CTEST: "true"
variables:
MODULE_LIST: cmake/3.30.5 ninja/1.11.1 gcc/12.1.1
MODULE_LIST: cmake/3.30.5 ninja/1.11.1 gcc/12.1.1 fftw/3.3.10

ERF_ENABLE_FFT: "ON"
extends: .job_on_dane
2 changes: 2 additions & 0 deletions .gitlab/LC/jobs/matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ matrix_cuda_12.9.1:
BUILD_TYPE: "RelWithDebInfo"
CMAKE_CXX_COMPILER: g++
CMAKE_C_COMPILER: gcc

ERF_ENABLE_FFT: "ON"
extends: .job_on_matrix
2 changes: 2 additions & 0 deletions .gitlab/LC/jobs/tuolumne.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ tuolumne_hip_6.4.0:
# NOTE: Running with Debug build type causes AMD linking errors with AMReX plotfiles=ON
BUILD_TYPE: "RelWithDebInfo"

ERF_ENABLE_FFT: "ON"

# RRTMGP/Kokkos options:
#ERF_ENABLE_EKAT=ON
#ERF_ENABLE_KOKKOS=ON
Expand Down
33 changes: 33 additions & 0 deletions Docs/sphinx_doc/SurfaceLayer.rst
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,39 @@ boundary layer depth would ever be diagnosed. The subgrid velocity scale

which vanishes for grid spacings of :math:`\Delta x < 5` km.

Surface Layer boundary on all faces
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

While the surface layer boundary condition is primarily used on the bottom z face (zlo), it can also be applied to all other domain sides.
This can allow MOST theory to be used on faces for simulating closed environments (e.g, cloud chamber).

To use the surface layer boundary on different faces, all existing MOST options are prefixed with the corresponding face name (`xlo`, `ylo`, `zlo`, `xhi`, `yhi` `zhi`).
For example,

::

xlo.type = "surface_layer"
ylo.type = "surface_layer"

erf.xlo.surface_layer.flux_type = MOENG
erf.xlo.most.surf_temp = 289.5
erf.xlo.most.surf_moist = 0.00765
erf.xlo.most.z0 = 0.000035
erf.xlo.most.zref = 0.03125
erf.xlo.most.average_policy = 1
erf.xlo.most.radius = 0

erf.ylo.surface_layer.flux_type = MOENG
erf.ylo.most.surf_temp = 289.5
erf.ylo.most.surf_moist = 0.00765
erf.ylo.most.z0 = 0.000035
erf.ylo.most.zref = 0.03125
erf.ylo.most.average_policy = 1
erf.ylo.most.radius = 0


Note that not all existing options are supported when using MOST on other faces (such as interpolation and time averaging).
Currently the `MOENG` flux type is supported on all faces.

Prescribed time-varying surface forcing
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand Down
116 changes: 116 additions & 0 deletions Docs/sphinx_doc/plotfiles/Plotfile3DReference.rst
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,122 @@ The default subvolume inventory is documented on :ref:`sec:Plotfiles`.
| | to be defined |
| | [count] |
+-----------------------------+------------------+
| **Tau11** | Subgrid stress |
| | component 11. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau12** | Subgrid stress |
| | component 12. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau13** | Subgrid stress |
| | component 13. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau21** | Subgrid stress |
| | component 21. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau22** | Subgrid stress |
| | component 22. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau23** | Subgrid stress |
| | component 23. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau31** | Subgrid stress |
| | component 31. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau32** | Subgrid stress |
| | component 32. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **Tau33** | Subgrid stress |
| | component 33. |
| | Only available |
| | when diffusion |
| | is enabled |
| | [kg/m/s^2] |
+-----------------------------+------------------+
| **hfx1** | Heat flux in |
| | x-direction. |
| | Only available |
| | with X surface |
| | layers enabled |
| | [W/m^2] |
+-----------------------------+------------------+
| **hfx2** | Heat flux in |
| | y-direction. |
| | Only available |
| | with Y surface |
| | layers enabled |
| | [W/m^2] |
+-----------------------------+------------------+
| **hfx3** | Heat flux in |
| | z-direction. |
| | Only available |
| | with Z surface |
| | layers enabled |
| | [W/m^2] |
+-----------------------------+------------------+
| **q1fx1** | Moisture flux 1 |
| | in x-direction. |
| | Only available |
| | with X surface |
| | layers and |
| | moisture enabled |
| | [kg/m^2/s] |
+-----------------------------+------------------+
| **q1fx2** | Moisture flux 1 |
| | in y-direction. |
| | Only available |
| | with Y surface |
| | layers and |
| | moisture enabled |
| | [kg/m^2/s] |
+-----------------------------+------------------+
| **q1fx3** | Moisture flux 1 |
| | in z-direction. |
| | Only available |
| | with Z surface |
| | layers and |
| | moisture enabled |
| | [kg/m^2/s] |
+-----------------------------+------------------+
| **q2fx3** | Moisture flux 2 |
| | in z-direction. |
| | Only available |
| | with Z surface |
| | layers and |
| | moisture enabled |
| | [kg/m^2/s] |
+-----------------------------+------------------+

The ``qrain``, ``qsnow``, and ``qgraup`` rows are available when the active
moisture scheme provides the corresponding rain, snow, or graupel component.
Expand Down
9 changes: 6 additions & 3 deletions Source/BoundaryConditions/ERF_MOSTAverage.H
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@ public:
/**
* Construct the MOST averaging helper.
*
* @param[in] face orientation of face for MOST averaging
* @param[in] geom geometry for all AMR levels
* @param[in] has_zphys whether nodal physical-height data are available
* @param[in] a_pp_prefix ParmParse prefix
* @param[in] m_mesh_type mesh type
* @param[in] m_terrain_type terrain representation
* @param[in] eb_vec optional embedded-boundary geometry data
*/
explicit MOSTAverage (amrex::Vector<amrex::Geometry> geom,
explicit MOSTAverage (amrex::Orientation face,
amrex::Vector<amrex::Geometry> geom,
const bool& has_zphys,
std::string a_pp_prefix,
const MeshType& m_mesh_type,
Expand Down Expand Up @@ -402,6 +404,7 @@ protected:

// Passed through constructor
//--------------------------------------------
amrex::Orientation m_face; // Face to perform averages on
const amrex::Vector<amrex::Geometry> m_geom; // Geometry at each level
amrex::Vector<amrex::Vector<amrex::MultiFab*>> m_fields; // Ptr to fields to be averaged
amrex::Vector<amrex::MultiFab*> m_z_phys_nd; // Ptr to terrain height coords
Expand All @@ -411,8 +414,8 @@ protected:

// General vars for multiple or all policies
//--------------------------------------------
int m_nvar{6}; // 6 fields for U/V/T/Qv/Qr/W
int m_navg{6}; // 6 averages for U/V/T/Qv/Tv/Umag
int m_nvar{6}; // 6 fields for U/V/W/T/Qv/Qr
int m_navg{9}; // 9 averages for U/V/W/T/Qv/Tv/Umag_XY,Umag_XZ,Umag_YZ
int m_maxlev{0}; // Total number of levels
int m_policy{0}; // Policy for type of averaging
bool m_rotate{false}; // Do vector rotations for terrain?
Expand Down
Loading
Loading