Repository navigation
spec: confirmation queue, recall provenance labels, widened activity aperture - #294
equationalapplications wants to merge 26 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
|
✅ Reviewed Last run: 2026-10-21 21:21 UTC |
…le channel (M1), deny suppression (M2), minors
…-spoof, durability/sync), ruling R-B remote-verification roadmap
…mations.jsonl durability (B2), removed-tool premise (M1), sibling-safe deny key (M3), confidence ordinal (M4), per-hit source_type labels (M5), direct-write retirement (M6), minors
…struction handles, content-hash rebuild match, ledger ingest tier)
…ry reviewer rulings into Tasks 2/11
…); park B6 + orphan-stamp finding
…12ab); route C4 to Task 10, N1 spoof test to Task 11
d25b102); bind D6 replay-flake convention
…ute E2 deferral and Low findings to Task 11
…; route Low-1 test gap to Task 11, close N+1 in Task 7
![aws-cloud-agent-pr-review[bot]](https://avatars.githubusercontent.com/u/65428263?s=60&v=4){kind=small}
There was a problem hiding this comment.
Adds a human-tier gate and confirmation queue infrastructure. The diff correctly implements the spec's human/agent tier separation and read-only queue query, but introduces a potential data integrity issue in the deposit_attribution index where a missing speaker value would violate the NOT NULL constraint.
| -- carrier; this table is a derived brain-side cache keyed by document path, | ||
| -- written inside the same audit_and_seed_kick transaction as the audit and | ||
| -- kick-ledger rows (wisdom_deposit.rs). A re-ingest repopulates the index | ||
| -- from the file. |
There was a problem hiding this comment.
Advisory. This bot's findings are usually wrong (measured precision ~2–5%). No reply needed. If you do check it: reply
false: <one-line reason>if it's wrong, or fix it and say so if it's right.
major · data-integrity
deposit_attribution speaker column is NOT NULL but the spec allows None.
Failure scenario: A deposit with an empty or missing speaker (e.g., via a malformed frontmatter or a future spec change) causes the INSERT to fail with a constraint violation, breaking the deposit pipeline.
Suggested fix: Change the column definition to speaker TEXT (nullable) to match the spec's allowance for missing attribution, or add a runtime guard to reject deposits without a speaker.
| /// ONLY when this flag is `true` AND `auto_approve` is `false`. Set ONLY | ||
| /// by the desktop app's resolve path (`proposals_api.rs`); CLI, MCP, and | ||
| /// internal-API approvals resolve at agent tier (`librarian_inferred`) | ||
| /// and write an `approved_at_agent_tier` event. Never derived from a |
There was a problem hiding this comment.
Advisory. This bot's findings are usually wrong (measured precision ~2–5%). No reply needed. If you do check it: reply
false: <one-line reason>if it's wrong, or fix it and say so if it's right.
major · logic-flaw
human_surface flag is not enforced in commit logic
Failure scenario: When human_surface is true, the code does not guarantee that user_confirmed provenance is stamped; the flag is only used in review_shim.rs and proposals_api.rs, not in the actual commit transaction.
1 participant
What
Rev-1 spec for the pending-user-confirmation queue, per Kurt's rulings of 2026-10-20/21 (all decisions resolved — S1/S2, Active Verification Prompting ruling, D1–D8).
Spec:
docs/superpowers/specs/2026-10-20-user-confirmation-queue-design.mdCovers: deposit-file attribution carrier; the unverified-facts queue (app-only confirm, read-only MCP queue list); Active Verification Prompting modal; recall provenance labels (
ct wisdom matchuntouched); #282 §5 rev-15 delta (activity aperture admitsuser_stated+user_confirmed,immutable_documentexcluded); Path Bstated/<author>/<year>/attested-file pipeline; full INTENT.md amendment text (Rules 2/3/8, new Rule 10, glossary, new \u201cWho verifies: users and scope\u201d section).Provenance
records/investigations/2026-10-20-confirm-queue-fable-consult/memo-run1.md(vault is outside this repo)immutable-source-files/agents/memories/confirm-queue-aperture-decision-2026-10-20.mdrecords/handoffs/2026-10-19-handoff-user-confirmation-queue.md(vault)Review plan (per dual-review-cycle; this PR stays DRAFT until implementation completes)
--docwith INTENT.md + code context)Per the delivery flow: spec + plan + implementation all travel in this ONE PR; nothing merges until implementation is done and reviewed (curated-thoughts: regular merges only).