Repository navigation
fix(tanstack-start): cut redundant OMSA ticket requests on homepage a… - #207
Open
jorgenosberg wants to merge 1 commit into
Open
jorgenosberg wants to merge 1 commit into
jorgenosberg wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the changes or their storage and query integrations.
0 open findings
What changed in this PR
Reduces redundant OMSA ticket requests on the homepage and during environment switches.
Changes:
- Shares scope-aware local ticket loading between ticket views.
- Fetches homepage travel documents only for confirmed packages.
- Removes per-query retry overrides.
| File | Description |
|---|---|
clients/tanstack-start/src/routes/tickets/index.tsx |
Uses shared stored-package loading and reload behavior. |
clients/tanstack-start/src/hooks/use-stored-packages.ts |
Prevents stale-scope package IDs from triggering requests. |
clients/tanstack-start/src/components/search/ActiveTicketsSection.tsx |
Uses shared loading and gates document requests on confirmation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Docker Scan - Alert(s) found with threshold matching severity highResults
Docker Scan Report can be found here AllowlistUse the allowlist if you want to ignore vulnerabilities that do not affect the repository. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd env switch