Skip to content

Feat: Adds a new module for Valkey memorystore - #75

Open
xamebax wants to merge 23 commits into
mainfrom
CLOUD-4163-add-valkey-module
Open

Feat: Adds a new module for Valkey memorystore#75
xamebax wants to merge 23 commits into
mainfrom
CLOUD-4163-add-valkey-module

Conversation

@xamebax

@xamebax xamebax commented Apr 21, 2026

Copy link
Copy Markdown
  • Module enables creating a new Valkey memorystore instance from scratch, in a shared VPC, and using Private Service Connect.
  • The only possible authorization mode is via IAM.
  • The only possible zone distribution mode for Valkey is multizone.
  • While we enable to use both cluster and non-cluster mode, we encourage cluster mode by setting that as the default mode for a Valkey instance.
  • Uses a test module for local testing.

Done with @Spikra and @alovh.

Ref. CLOUD-4163.

Spikra and others added 18 commits April 9, 2026 12:23
@Spikra
feat: add valkey memorystore folder structure
561af21
@xamebax @Spikra @alovh
[WIP] Initial work with a new memorystore module for Valkey.
ae772b4 
Co-authored-by: Espen Blikra <Spikra@users.noreply.github.com>
Co-authored-by: Anne Løvhaugen <alovh@users.noreply.github.com>
@alovh
chore: check defaults for engine_configs
d8b60f6
@xamebax
Add locals required for configuring a new valkey instance
b9f992a
@xamebax
Valkey: Adds minimal examples to test module locally
d252bc8
@alovh
chore: Add more todos
220822e
@xamebax
WIP: Set a service connection policy
a26516a
@alovh
chore: Add defaults to mode and shard_count
fc99495
@Spikra
feat: adding initial google_memorystore_instance
22fcba8
@xamebax
Valkey: updates test arguments
c457d85
@xamebax
Valkey: use a safer cidr
bf49811
@xamebax @Spikra @alovh
WIP: A working module that can create a new instance.
20dd6f4 
Co-authored-by: Espen Blikra <Spikra@users.noreply.github.com>
Co-authored-by: Anne Løvhaugen <alovh@users.noreply.github.com>
@xamebax @Spikra @alovh
Remove unnecessary kubernetes provider
dd64043 
Co-authored-by: Espen Blikra <Spikra@users.noreply.github.com>
Co-authored-by: Anne Løvhaugen <alovh@users.noreply.github.com>
@xamebax @Spikra @alovh
WIP: Clean up, expand, test
876603b 
Co-authored-by: Espen Blikra <Spikra@users.noreply.github.com>
Co-authored-by: Anne Løvhaugen <alovh@users.noreply.github.com>
@xamebax @alovh
WIP: valkey module
72b0efc 
Co-authored-by: Anne Løvhaugen <alovh@users.noreply.github.com>
@xamebax @alovh @Spikra
WIP: Clean up network and connection string, among others. Also don't…
dcaac63 
… set default Valkey version

Co-authored-by: Anne Løvhaugen <alovh@users.noreply.github.com>
Co-authored-by: Espen Blikra <Spikra@users.noreply.github.com>
@xamebax
WIP small fixes.
86c7f9d
@xamebax
finishinf touches to valkey module: cleanup and format
e1141a1
@xamebax
xamebax requested a review from a team as a code owner April 21, 2026 10:21
@sonarqubecloud

sonarqubecloud Bot commented Apr 21, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@xamebax @claude
Add integration tests for Valkey module (#76)
a295591 
* add integration tests for the Valkey module

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix failing tests (wrong app id and env)

* fixes sonarqube fails; we don't pin our own workflows to a commit

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alovh alovh alovh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xamebax @alovh @Spikra