jdk 25 and spring boot 4.1 - #637
Merged
Merged
Conversation
spring-cloud-gcp 8.1.0 is the same code as 7.4.10 rebuilt against Spring Boot 4; 7.4.10 compiles against spring-boot-autoconfigure 3.5.3. The chart gains the JDK 25 native-access and Unsafe flags, guarded by IgnoreUnrecognizedVMOptions so the chart still boots if it ever meets a pre-JDK-24 image. New docker-smoke job starts the built image and gates docker-push; it disables the Cloud SQL autoconfiguration, which otherwise fails in prepareEnvironment before the app logs anything.
There was a problem hiding this comment.
Pull request overview
Updates Nabu’s build, runtime image, and CI pipeline to run on JDK 25 and align dependencies with Spring Boot 4.1 (including Spring Cloud GCP rebuilt for Boot 4), plus adds a Docker image smoke test gate before pushing images.
Changes:
- Bump parent/superpom and Spring Cloud GCP dependency management to the Spring Boot 4 line.
- Upgrade Docker base images to Liberica OpenJRE 25 and adjust Helm JVM options for JDK 25 native/Unsafe access flags.
- Add a
docker-smokeGitHub Actions job to build/run the image and gatedocker-push.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
pom.xml |
Updates parent and Spring Cloud GCP BOM version; adjusts dependency management notes. |
helm/nabu/values.yaml |
Adds JDK 25 JVM flags (native-access / Unsafe) to JDK_JAVA_OPTIONS. |
Dockerfile |
Moves builder/runtime base images to Liberica OpenJRE Alpine 25.0.4. |
CLAUDE.md |
Updates documented Java version (but needs Boot/CI job list alignment). |
.github/workflows/push.yml |
Uses Java 25 in CI and adds docker-smoke gating for docker-push. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spring-cloud-gcp 8.1.0 is the same code as 7.4.10 rebuilt against Spring Boot 4; 7.4.10 compiles against spring-boot-autoconfigure 3.5.3. The chart gains the JDK 25 native-access and Unsafe flags, guarded by IgnoreUnrecognizedVMOptions so the chart still boots if it ever meets a pre-JDK-24 image. New docker-smoke job starts the built image and gates docker-push; it disables the Cloud SQL autoconfiguration, which otherwise fails in prepareEnvironment before the app logs anything.