Repository navigation
fix(data): merge product object roles and read localized live parts - #35
Merged
nichinichisou0609 merged 2 commits intoOct 17, 2026
Merged
Conversation
Combine compatible file roles from shared objects and reject conflicting metadata or file entries. Support region directories in product paths. Keep language-indexed UI resources separate from shared live part paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live indexes can include a language-to-manifest map in
parts.ui. The reader now keeps that map separate from the shared scene, score and audio paths, so these live products load successfully.Product loading also combines complementary file roles of the same object. Overlapping roles and object metadata must agree, and manifest paths can include region directories. This logic is shared by product readers.
CI and commit-message checks run for pull requests targeting any branch.
Validation: 12 product and live loader tests pass, including localized UI indexes, compatible role merging and conflicting file detection. Build, lint, type checking and contract checks pass.