Skip to content

fix(story): play the voices on the Voice category - #29

Closed
luoxiadesu wants to merge 1 commit into
empty-sekai:mainfrom
StarMoe-org:fix/story-voice-category
Closed

luoxiadesu wants to merge 1 commit into
empty-sekai:mainfrom
StarMoe-org:fix/story-voice-category

Conversation

@luoxiadesu

Copy link
Copy Markdown
Collaborator

Problem

On bdon.moe's story player, the music volume slider also turns down (and the music mute silences) the voices of the
linkstory episodes ADV 10579–10608 (e.g. https://bdon.moe/en/tools/story-player?story=10579).

Their episodes' -Sound rows put the voice cues on Bgm (_category 0); every other episode has Voice (2):

ADV asset voice _category
10570–10578 adv_script_{nagi,mahoro,houka}_…_linkstory_* 2
10579–10608 adv_script_{raika,miku,yomogi,chieri,shizuku}_…_linkstory_* 0
10609– tutorial, home 2

Audio.play routes a cue to the bus of its row's category, so these voices played on the Bgm bus.

Change

  • tryPlayVoice (Talk and Voice rows, and the simple player) plays every voice on the Voice category whatever its
    row says, marked as a deviation in the comment.
  • Audio.play / SilentAudio.play take an optional category overriding the resolved cue's; without it they play
    as before (BGM and SE unchanged).
  • docs/story.md lists the departure under Fidelity.

Checks

  • npm test (670 pass), npm run lint, npm run typecheck, npm run contract:check after a build.
  • New tests: the override's bus and stopAll in engine-audio.test.mjs (Audio and SilentAudio); the Voice row's
    category in story-feature-voice.test.mjs.
  • On the published episode data of ADV 10579: adv_voice_linkstory_raika_miku_10579_001 (row Bgm) plays on Voice;
    sound_bgm_adv_cafe_time stays on Bgm.

🤖 Generated with Claude Code

The -Sound rows of the linkstory episodes ADV 10579-10608 put their
voices on Bgm (_category 0) where every other episode has Voice (2).
The voices then played on the Bgm bus, so the music volume turned them
down and muting the music silenced them.

tryPlayVoice now plays every voice of a Talk or Voice row on the Voice
category whatever its row says: Audio.play and SilentAudio.play take an
optional `category` that overrides the resolved cue's. Without it they
play as before. docs/story.md lists this departure from the data.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nichinichisou0609

Copy link
Copy Markdown
Contributor

Superseded by #34. The cue sheet of these voices (adv_voice_linkstory_*) puts every cue in the CRI categories Voice/VoiceConfig, and the volume of a CRI category reaches a cue through its sheet's categories; the sound row's _category only decides what a category stop and a BGM crossfade reach. #34 routes the bus by the sheet's categories and leaves the row's category for stops, so a Bgm row still fades its voice out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants