Repository navigation
fix(story): play the voices on the Voice category - #29
Closed
luoxiadesu wants to merge 1 commit into
Closed
luoxiadesu wants to merge 1 commit into
luoxiadesu wants to merge 1 commit into
Conversation
The -Sound rows of the linkstory episodes ADV 10579-10608 put their voices on Bgm (_category 0) where every other episode has Voice (2). The voices then played on the Bgm bus, so the music volume turned them down and muting the music silenced them. tryPlayVoice now plays every voice of a Talk or Voice row on the Voice category whatever its row says: Audio.play and SilentAudio.play take an optional `category` that overrides the resolved cue's. Without it they play as before. docs/story.md lists this departure from the data. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Superseded by #34. The cue sheet of these voices (adv_voice_linkstory_*) puts every cue in the CRI categories Voice/VoiceConfig, and the volume of a CRI category reaches a cue through its sheet's categories; the sound row's _category only decides what a category stop and a BGM crossfade reach. #34 routes the bus by the sheet's categories and leaves the row's category for stops, so a Bgm row still fades its voice out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On bdon.moe's story player, the music volume slider also turns down (and the music mute silences) the voices of the
linkstory episodes ADV 10579–10608 (e.g. https://bdon.moe/en/tools/story-player?story=10579).
Their episodes'
-Soundrows put the voice cues on Bgm (_category0); every other episode has Voice (2):_categoryadv_script_{nagi,mahoro,houka}_…_linkstory_*adv_script_{raika,miku,yomogi,chieri,shizuku}_…_linkstory_*Audio.playroutes a cue to the bus of its row's category, so these voices played on the Bgm bus.Change
tryPlayVoice(Talk and Voice rows, and the simple player) plays every voice on the Voice category whatever itsrow says, marked as a deviation in the comment.
Audio.play/SilentAudio.playtake an optionalcategoryoverriding the resolved cue's; without it they playas before (BGM and SE unchanged).
docs/story.mdlists the departure under Fidelity.Checks
npm test(670 pass),npm run lint,npm run typecheck,npm run contract:checkafter a build.stopAllinengine-audio.test.mjs(Audio and SilentAudio); the Voice row'scategory in
story-feature-voice.test.mjs.adv_voice_linkstory_raika_miku_10579_001(row Bgm) plays on Voice;sound_bgm_adv_cafe_timestays on Bgm.🤖 Generated with Claude Code