Repository navigation
fix(sim): leave non-playable characters out of the character list - #66
Merged
Merged
Conversation
MasterCharacter rows read the optional `_isNonPlayable` column (absent means false). A player save lists only playable characters, so account resolution no longer requires an unlisted non-playable character under a partial character list, and complete coverage leaves it out of the total character rank. A listed non-playable character is read like any other. The owned-snapshot input applies the same rule to its rank checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MasterCharacterrows read the optional_isNonPlayablecolumn (absent means false).docs/account-input.mddescribes the rule.Tests
a_partial_character_list_requires_only_unlisted_playable_characterscomplete_character_coverage_leaves_non_playable_characters_out_of_the_total🤖 Generated with Claude Code