Skip to content

Add optional reviewed inventory integration for Deck R3 - #1

Merged
nichinichisou0609 merged 2 commits into
mainfrom
feat/ocr-roster-recommendation-r3
Oct 2, 2026
Merged

nichinichisou0609 merged 2 commits into
mainfrom
feat/ocr-roster-recommendation-r3

Conversation

@nichinichisou0609

@nichinichisou0609 nichinichisou0609 commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Connect reviewed BoxLens screenshots to the OurNotes Deck R3 recommendation interface. The optional deck-ui entry preserves unknown/conflicting observations until explicit completion, validates growth and ownership against the bound master, and exports the existing Roster schema. Scoring and search remain in ournotes-deck.

Reusing an output directory now revokes the previous completed review before changing inventory. Failed or partial adaptation leaves a pending marker; only publishing completion, adaptation and roster clears it. Recommendation verifies the current inventory and reviewed roster, and HTTP reload reads and verifies one snapshot under the same lock used by adaptation. Valid historical R3 workspaces remain supported; stale teams and baselines are excluded after input changes. Explicit added/excluded identities require nonempty per-identity evidence.

The UI preserves scenario selection and rejects stale responses. Raw uploaded JSON and actual DeckData/Roster bytes retain the existing validation and frozen-input behavior. Game art, master/chart payloads, screenshots, native binaries and credentials are not included.

Validation:

  • Current Python suite: 65 passed, including failure after a previous successful adaptation, refusal to invoke the solver with stale review, successful recovery, partial-write rejection, matching legacy review, per-identity evidence, and bounded HTTP GET/mutation-lock checks.
  • Follow-up fixes were reviewed against the original PR head in an isolated worktree; unrelated later local changes are excluded.
  • Original PR validation remains historical: 49 tests, 16 official-entrypoint browser checks, and independent R3 QA 45 PASS / 0 FAIL / 2 BLOCKED. Those browser/OCR/full-pipeline checks were not rerun for this follow-up. The two original blocked cases lack Arena rows in the frozen JP master.

This is an optional legacy R3 integration. Users must explicitly provide a compatible recommendation-request/1 solver executable (the delivered R3 build); normal BoxLens scan/serve commands remain independent of Deck. The closed state of ournotes-deck #3 does not prevent using that executable. Current-core Draft #5 and a formal browser WASM resolver are not supported by this integration. Original numerical claims remain conditional on the declared finite root law and offline native 1.0.1-25 model; current JP 1.0.4 full-runtime equivalence is not claimed.

@nichinichisou0609
nichinichisou0609 marked this pull request as draft October 2, 2026 00:24
@nichinichisou0609 nichinichisou0609 changed the title Connect reviewed BoxLens inventories to Deck R3 recommendations Add optional reviewed inventory integration for Deck R3 Oct 2, 2026
@nichinichisou0609
nichinichisou0609 marked this pull request as ready for review October 2, 2026 00:32
@nichinichisou0609
nichinichisou0609 merged commit 47f1405 into main Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant