Repository navigation
Add optional reviewed inventory integration for Deck R3 - #1
Merged
Merged
Conversation
nichinichisou0609
marked this pull request as draft
October 2, 2026 00:24
nichinichisou0609
marked this pull request as ready for review
October 2, 2026 00:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect reviewed BoxLens screenshots to the OurNotes Deck R3 recommendation interface. The optional
deck-uientry preserves unknown/conflicting observations until explicit completion, validates growth and ownership against the bound master, and exports the existing Roster schema. Scoring and search remain in ournotes-deck.Reusing an output directory now revokes the previous completed review before changing inventory. Failed or partial adaptation leaves a pending marker; only publishing completion, adaptation and roster clears it. Recommendation verifies the current inventory and reviewed roster, and HTTP reload reads and verifies one snapshot under the same lock used by adaptation. Valid historical R3 workspaces remain supported; stale teams and baselines are excluded after input changes. Explicit added/excluded identities require nonempty per-identity evidence.
The UI preserves scenario selection and rejects stale responses. Raw uploaded JSON and actual DeckData/Roster bytes retain the existing validation and frozen-input behavior. Game art, master/chart payloads, screenshots, native binaries and credentials are not included.
Validation:
This is an optional legacy R3 integration. Users must explicitly provide a compatible recommendation-request/1 solver executable (the delivered R3 build); normal BoxLens scan/serve commands remain independent of Deck. The closed state of ournotes-deck #3 does not prevent using that executable. Current-core Draft #5 and a formal browser WASM resolver are not supported by this integration. Original numerical claims remain conditional on the declared finite root law and offline native 1.0.1-25 model; current JP 1.0.4 full-runtime equivalence is not claimed.