Repository navigation
feat!: port JP7 game rules and prepare 0.1.0 - #45
Merged
Merged
Conversation
Preserve multidimensional area-item effects, gate selection, and upgrade evaluation across the engine, CLI, HTTP, and WASM APIs. Integrate mixed-unit power states and finale shuffle bonuses into exact search bounds and result reporting. Co-Authored-By: Claude Code <noreply@anthropic.com>
nichinichisou0609
force-pushed
the
feat/jp7-rules
branch
from
October 2, 2026 13:26
84126a0 to
e24030a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior
JP7 area items and World Link finales now use the current game-rule model across the Rust, CLI, HTTP and WASM interfaces. Finale events are identified from master data, skill caps retain their raw values, and explicit shuffle tables feed both scoring and admissible search bounds.
The business rules are ported from Team-Haruki/sekai-deck-recommend-cpp, pinned to
496caed78a07ffe1f2d1f1553047dbf6b2ed0314. The source map indocs/game-rule-sources.mdidentifies the files and attributes the additional master-table and browser integration cases to Moesekai's published patches. Existing Rust skill corrections remain in place.Finale callers can explicitly request mandatory-member constraints without assigning the first fixed item as leader. The default ordered-slot contract is unchanged. Ordinary finale Top-K supports all objectives; mandatory-member requests combined with exact bonus tiers are rejected. Requests without mandatory members retain the existing fast paths and tier support.
Release
Prepare 0.1.0, including the public API changes since 0.0.15. Native binaries and both WASM packages are checked as one complete asset set with SHA256SUMS. Manual release preflight builds and validates without publishing. Tag publication uses the tested npm tarball and verifies registry integrity, including recovery when an identical version was already uploaded.
Both READMEs, the npm README, and the versioned release notes explicitly credit the business-rule source.
Validation
The successful release preflight is run 37726382888 at 8e4fad1. The follow-up only updates the HTTP OpenAPI version and parameter documentation; native and WASM package sources are unchanged, and the HTTP tests were rerun successfully.