Skip to content

CI: get the correct minor version when bumping #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmercm merged 2 commits into from
Apr 24, 2026
Merged

CI: get the correct minor version when bumping #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9dba78
CI: get the correct minor version when bumping
emmercm Apr 24, 2026
cbe6b67
SC2129
emmercm Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions .github/workflows/maxcso-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,27 @@ env:
MAXCSO_REF: ${{ inputs.maxcso_ref || 'refs/heads/master' }}

jobs:
get-version:
runs-on: ubuntu-latest
outputs:
major: ${{ steps.parse-version.outputs.major }}
minor: ${{ steps.parse-version.outputs.minor }}
patch: ${{ steps.parse-version.outputs.patch }}
steps:
- uses: actions/checkout@v4
with:
repository: unknownbrackets/maxcso
ref: ${{ env.MAXCSO_REF }}
- id: parse-version
run: |
set -euo pipefail
version=$(grep 'VERSION = ' src/compress.h | sed -E 's/.*"([0-9.]+)".*/\1/')
{
echo "major=$(echo "${version}" | sed -E 's/([0-9]+)\..*/\1/')"
echo "minor=$(echo "${version}" | sed -E 's/[0-9]+\.([0-9]+)\..*/\1/')"
echo "patch=$(echo "${version}" | sed -E 's/[0-9]+\.[0-9]+\.([0-9]+).*/\1/')"
} >> "${GITHUB_OUTPUT}"

build-linux:
name: build-linux ${{ matrix.nodejs_arch }}
strategy:
Expand Down Expand Up @@ -80,8 +101,17 @@ jobs:
run: |
set -x
./maxcso --help || true
readelf -d dolphin-tool
file maxcso
if ! file maxcso | grep -qE 'statically linked|static-pie linked'; then exit 1; fi
if readelf -d dolphin-tool | grep -q NEEDED; then
echo "ERROR: binary has dynamic dependencies, expected fully static"
readelf -d dolphin-tool | grep NEEDED
exit 1
fi
if ! file dolphin-tool | grep -qE 'statically linked|static-pie linked'; then
echo "ERROR: 'file' does not report the binary as statically linked"
exit 1
fi
- name: Rename binary
run: |
dir="artifacts/packages/maxcso-linux-${{ matrix.nodejs_arch }}"
Expand Down Expand Up @@ -289,6 +319,7 @@ jobs:

git-update:
needs:
- get-version
- build-linux
- build-macos
- build-windows
Expand All @@ -303,8 +334,7 @@ jobs:
run: |
package_name=$(jq --raw-output '.name' packages/maxcso/package.json)
major_version=$(npm show "${package_name}" --json | jq --raw-output '.versions | .[]' | sed 's/\.[0-9]*//g' | sort | tail -1)
# shellcheck disable=SC2001
minor_version=$(echo "${MAXCSO_REF}" | sed 's/[^0-9]*//g' | sed 's/^0*//')
minor_version=${{ needs.get-version.outputs.major }}${{ needs.get-version.outputs.minor }}${{ needs.get-version.outputs.patch }}
previous_version=$(npm show "${package_name}" --json | jq --raw-output '.versions | .[]' | grep "${minor_version}" | tail -1)
if [[ "${previous_version}" != "" ]]; then
# shellcheck disable=SC2001
Expand Down
Loading