Clarify wording of IdTypeMap::remove_by_type documentation - #8364
Open
the-maddin wants to merge 1 commit into
Open
Clarify wording of IdTypeMap::remove_by_type documentation#8364the-maddin wants to merge 1 commit into
the-maddin wants to merge 1 commit into
Conversation
|
Preview available at https://egui-pr-preview.github.io/pr/8364-idtypemap-doc View snapshot changes at kitdiff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function to remove all entries of a type from IdTypeMap was confusingly documented as "Note all state of the given type".
As far as I know, (not a native speaker), "noting" shares no meaning with "removing", so I changed the doc to simply state what the function does.