Fix problems with prettier v3.6.0+

[evoactivity]

Supercedes #407
Closes #406

[evoactivity]

Can I get opinions please @NullVoxPopuli @gitKrystan

The failure is with semi: false, I think the new output is actually correct, we have this same expectation for prettier to add in an ASI in a different typescript file already

// config > semi: false > it formats ../cases/gts/implied-export-default-satisfies.gts
import type { TemplateOnlyComponent } from "@ember/component/template-only"

;<template>
  Implied Export Default with Satisfies
</template> satisfies TemplateOnlyComponent

[fisker]

Is there a problem switching to TaggedTemplateExpression?

[fisker]

Is it causing parse failure?

[evoactivity]

There were quite a few problems with how tagged templates ended up formatting, breaking our expectations of how a template tag should be output.

Some examples comparing the two approaches.

We have about 80 test cases for these idiosyncrasies that fail when using the tagged template approach.

My problem was I didn't fully understand what innerComments was actually being used for (to remove the comment from the AST so prettier wouldn't expect it to be printed as a comment). The comment approach should be fine for us.

[NullVoxPopuli]

I think the comment was for keeping overall character length the same?

[evoactivity]

@fisker I do have a question actually

On versions 3.6.0, 3.6.1 and 3.6.2 our // prettier-ignore tests fail (as path.node?.leadingComments is now always undefined), but begin passing again on 3.7.x. Looks like there was work done here but I don't understand how that is now making things work for us as I didn't do anything to the ignore code in this plugin (and if I remove that code completely our tests still pass on 3.7.x). Was just curious why those changes (or maybe some other changes) made it all work for us again.

[evoactivity]

I think the comment was for keeping overall character length the same?

Yeah partly that, and partly because the formatting around an ObjectExpression/StaticBlock/BlockStatement that only contains a comment, works in such a way that matches our expectations for how templates should be treated as part of the JS. My attempts at using an object with a key and string or a tagged template resulted in a lot of differences around line breaks, ASI etc.

[evoactivity]

Ready for review.
I've tested with 3.5.3, 3.6.0, 3.6.1, 3.6.2, 3.7.0, 3.7.1, 3.7.2, 3.7.3

All work as expected.

[NullVoxPopuli]

can we add all those minor versions to CI?

@embroider/try should help out, like how we do with library testing

[NullVoxPopuli]

what do 1 and 7 represent?

[evoactivity]

The offsets from the original template don't always match the offsets of the AST comments due to the prefix and suffix.

start + 1 = {
start + 7 = static{
end - 1 = }

eg template start is 14 in a class component. AST sees /*the template */ so starts at 21. So bump the template start to 21 to account for static{ before the comment begins and we can match.

[evoactivity]

can we add all those minor versions to CI?

@embroider/try should help out, like how we do with library testing

We should, better in a different PR though

[fisker]

@fisker I do have a question actually

On versions 3.6.0, 3.6.1 and 3.6.2 our // prettier-ignore tests fail (as path.node?.leadingComments is now always undefined), but begin passing again on 3.7.x. Looks like there was work done here but I don't understand how that is now making things work for us as I didn't do anything to the ignore code in this plugin (and if I remove that code completely our tests still pass on 3.7.x). Was just curious why those changes (or maybe some other changes) made it all work for us again.

print function won't receive ignored nodes, if you want access, add printPrettierIgnored.

estree plugin use the same function for print and printPrettierIgnored.