Skip to content

Repro for #374 #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NullVoxPopuli wants to merge 2 commits into from
Closed

Repro for #374 #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
961561d
Repro for #374
NullVoxPopuli Jul 2, 2025
01b9328
Update snapshots
NullVoxPopuli Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tests/cases/gts/issue-374.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<template>
…
</template> satisfies unknown;
22 changes: 22 additions & 0 deletions tests/unit-tests/__snapshots__/format.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,23 @@ class MyComponent extends Component {
"
`;

exports[`format > config > default > it formats ../cases/gjs/component-class-with-template-literal.gjs 2`] = `
Copy link
Copy Markdown
Collaborator

@gitKrystan gitKrystan Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up w/ the snapshot updates that are unrelated to the case you added? 🤔

Copy link
Copy Markdown
Member Author

@NullVoxPopuli NullVoxPopuli Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could hint at main being out of date? unsure

"import Component from "@glimmer/component";

/** It's a component */
class MyComponent extends Component {
<template>
<h1>
Class top level template. Class top level template. Class top level
template. Class top level template. Class top level template.
</h1>
</template>

what = \`template literal that is not a template\`;
}
"
`;

exports[`format > config > default > it formats ../cases/gjs/default-export.gjs 1`] = `
"<template>
Explicit default export module top level component. Explicit default export
Expand Down Expand Up @@ -570,6 +587,11 @@ export default class PooComponent extends Component {
"
`;

exports[`format > config > default > it formats ../cases/gts/issue-374.gts 1`] = `
"<template>…</template> satisfies unknown;
"
`;

exports[`format > config > default > it formats ../cases/gts/js-only.gts 1`] = `
"const num: number = 1;
"
Expand Down
11 changes: 11 additions & 0 deletions tests/unit-tests/ambiguous/__snapshots__/arrow-parens-avoid.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,6 +991,17 @@ oops => {};
"
`;

exports[`ambiguous > config > arrowParens: "avoid" > (oops) => {} > with semi, without newline > it formats ../cases/gjs/default-export.gjs 2`] = `
"<template>
Explicit default export module top level component. Explicit default export
module top level component. Explicit default export module top level
component. Explicit default export module top level component. Explicit
default export module top level component.
</template>
oops => {};
"
`;

exports[`ambiguous > config > arrowParens: "avoid" > (oops) => {} > with semi, without newline > it formats ../cases/gjs/exported-mod-var.gjs 1`] = `
"export const Exported = <template>
Exported variable template. Exported variable template. Exported variable
Expand Down
18 changes: 18 additions & 0 deletions tests/unit-tests/ambiguous/__snapshots__/index.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4217,6 +4217,24 @@ class MyComponent extends Component {
"
`;

exports[`ambiguous > config > default > ["oops"] > with semi, with newline > it formats ../cases/gjs/component-class-with-content-before-template.gjs 2`] = `
"import Component from "@glimmer/component";

/** It's a component */
class MyComponent extends Component {
get whatever() {}

<template>
<h1>
Class top level template. Class top level template. Class top level
template. Class top level template. Class top level template.
</h1>
</template>
["oops"];
}
"
`;

exports[`ambiguous > config > default > ["oops"] > with semi, with newline > it formats ../cases/gjs/default-export.gjs 1`] = `
"<template>
Explicit default export module top level component. Explicit default export
Expand Down
18 changes: 18 additions & 0 deletions tests/unit-tests/ambiguous/__snapshots__/semi-false.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4217,6 +4217,24 @@ class MyComponent extends Component {
"
`;

exports[`ambiguous > config > semi: false > ["oops"] > with semi, with newline > it formats ../cases/gjs/component-class-with-content-before-template.gjs 2`] = `
"import Component from "@glimmer/component"

/** It's a component */
class MyComponent extends Component {
get whatever() {}

<template>
<h1>
Class top level template. Class top level template. Class top level
template. Class top level template. Class top level template.
</h1>
</template>
["oops"]
}
"
`;

exports[`ambiguous > config > semi: false > ["oops"] > with semi, with newline > it formats ../cases/gjs/default-export.gjs 1`] = `
"<template>
Explicit default export module top level component. Explicit default export
Expand Down
22 changes: 22 additions & 0 deletions tests/unit-tests/config/__snapshots__/semi-false.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,23 @@ class MyComponent extends Component {
"
`;

exports[`config > semi: false > it formats ../cases/gjs/component-class-with-template-literal.gjs 2`] = `
"import Component from "@glimmer/component"

/** It's a component */
class MyComponent extends Component {
<template>
<h1>
Class top level template. Class top level template. Class top level
template. Class top level template. Class top level template.
</h1>
</template>

what = \`template literal that is not a template\`
}
"
`;

exports[`config > semi: false > it formats ../cases/gjs/default-export.gjs 1`] = `
"<template>
Explicit default export module top level component. Explicit default export
Expand Down Expand Up @@ -570,6 +587,11 @@ export default class PooComponent extends Component {
"
`;

exports[`config > semi: false > it formats ../cases/gts/issue-374.gts 1`] = `
";<template>…</template> satisfies unknown
"
`;

exports[`config > semi: false > it formats ../cases/gts/js-only.gts 1`] = `
"const num: number = 1
"
Expand Down
22 changes: 22 additions & 0 deletions tests/unit-tests/config/__snapshots__/template-export-default.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,23 @@ class MyComponent extends Component {
"
`;

exports[`config > templateExportDefault: true > it formats ../cases/gjs/component-class-with-template-literal.gjs 2`] = `
"import Component from "@glimmer/component";

/** It's a component */
class MyComponent extends Component {
<template>
<h1>
Class top level template. Class top level template. Class top level
template. Class top level template. Class top level template.
</h1>
</template>

what = \`template literal that is not a template\`;
}
"
`;

exports[`config > templateExportDefault: true > it formats ../cases/gjs/default-export.gjs 1`] = `
"export default <template>
Explicit default export module top level component. Explicit default export
Expand Down Expand Up @@ -570,6 +587,11 @@ export default class PooComponent extends Component {
"
`;

exports[`config > templateExportDefault: true > it formats ../cases/gts/issue-374.gts 1`] = `
"<template>…</template> satisfies unknown;
"
`;

exports[`config > templateExportDefault: true > it formats ../cases/gts/js-only.gts 1`] = `
"const num: number = 1;
"
Expand Down
15 changes: 15 additions & 0 deletions tests/unit-tests/config/__snapshots__/template-single-quote.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,21 @@ class MyComponent extends Component {
"
`;

exports[`config > singleQuote: false, templateSingleQuote: true > it formats quote-cases/component-class.gjs 2`] = `
"import Component from "@glimmer/component";

/** It's a component */
class MyComponent extends Component {
<template>
<h1 class='i-have-quotes'>
Class top level template. Class top level template. Class top level
template. Class top level template. Class top level template.
</h1>
</template>
}
"
`;

exports[`config > singleQuote: true, templateSingleQuote should inherit > it formats quote-cases/component-class.gjs 1`] = `
"import Component from '@glimmer/component';

Expand Down